Add config_export to Currency and CurrencyLocale ConfigEntityType annotation

Thanks! Does this solve a particular problem? Both entity classes already override ::toArray() to build the export array. Currencies definitely need additional logic to export usages. The annotation will not be sufficient to achieve that.

If you have a custom toArray() implementation, then this won't help you much, yes, so feel free to ignore it.

config_export can also be defined as a mapping, so if you want to use some_property in yaml and someProperty in the class, then you can do that with that now.

Question is, why exactly do you need a custom toArray() implementation?

I can see that the loop in Currency is a bit special, but CurrencyLocale doesn't seem to do anything special?

One problem with your implementation is that you also skip default functionality like dependencies, which are important for the config system. You probably don't have any, but the config system might still do something based on having a dependencies key or not..

The ::toArray() override stems from when we didn't have the mappings or dependencies. We should at least make sure the parent implementation is called.

Are you still working on this?

Working with exchange rates should not have been necessary. This is a bug for which I opened #2537510: Remove traces of old historical exchange rates.

One thing that is kind of confusing: Why do I have to explicitly set the exchangeRates in the CurrencyDeleteFormWebTest but none of the other attributes?

Did you see a config error, or something else?

1. +++ b/src/Entity/Currency.php
   @@ -128,17 +139,6 @@ class Currency extends ConfigEntityBase implements CurrencyInterface {
   -    if (isset($values['usages'])) {
   -      $usages_data = $values['usages'];
   -      $values['usages'] = [];
   -      foreach ($usages_data as $usage_data) {
   -        $usage = new Usage();
   -        $usage->setStart($usage_data['start'])
   -          ->setEnd($usage_data['end'])
   -          ->setCountryCode($usage_data['countryCode']);
   -        $values['usages'][] = $usage;
   -      }
   -    }
   

   Why is this removed? We'll still need to convert raw usage data to Usage objects, don't we?

2. +++ b/src/Entity/Currency.php
   @@ -398,28 +398,4 @@ class Currency extends ConfigEntityBase implements CurrencyInterface {
   -    foreach ($this->getUsages() as $usage) {
   -      $properties['usages'][] = array(
   -        'start' => $usage->getStart(),
   -        'end' => $usage->getEnd(),
   -        'countryCode' => $usage->getCountryCode(),
   -      );
   -    }
   

   Same here.

The patch contains some indentation errors (four spaces instead of two).

Parent classes can never be mocked. Methods on SUTs can be mocked, but not if it's the parent of the method you're trying to test. In this case the entity manager and typed config manager need to be mocked, as those are the dependencies ConfigEntityBase::toArray() tries to locate.

Cleaning patch and try to fix test failing, but seems that HEAD is failing. I don't providing interdiff because the previous patch was so far and I couldn't apply it.

And patch.

Thanks! Can you file this as a PR at https://github.com/bartfeenstra/drupal-currency? This project no longer uses drupal.org's testing infrastructure due to its limitations, so we use another CI through Github instead.

Rebased.

Converted the two toArray() unit test methods to kernel tests, which made them so much more useful and easier to work with. And the result is the same except that we now also get some standard keys in there.

Committed, finally.