"Undefined index" errors in system.install loading admin/reports/system

That error happens if you have missed to define which installation profile you have as part of your settings.php ...

I think though we better build some protection against that as part of the issue.

That error happens if you have missed to define which installation profile you have as part of your settings.php ...

I think though we better build some protection against that as part of the issue.

Yeah ...

Yeah ...

I don't see how this issue could not happen if you're using an installation profile other than standard. If you look at the code, we're pretending that installation profiles are modules, and I don't understand why:

$profile = drupal_get_profile();
    if ($profile != 'standard') {
      $info = system_get_info('module', $profile);
      $requirements['install_profile'] = [
        'title' => t('Installation profile'),
        'value' => t('%profile_name (%profile-%version)', [
          '%profile_name' => $info['name'],
          '%profile' => $profile,
          '%version' => $info['version']
        ]),
        'severity' => REQUIREMENT_INFO,
        'weight' => -9
      ];
    }

Try the above code in a drush script.

If we just use installation_profile_info($profile) instead of system_get_info, this won't happen. Is there any reason not to change this?

I was testing this issue locally using drupal 9.3, and it's not happening anymore, the code is now using:

$info = \Drupal::service('extension.list.module')->getExtensionInfo($profile);

The "getExtensionInfo" will properly return an array with the information. And the undefined index error will not happen.

But, I think we still have something to address here, the code uses both "name" and "version" from the profile, which means, it's expected that the "profile.info.yml" file has those keys, fortunately the "name" key is now required(maybe on D8 it wasn't), so in order to have a profile you must define a name for it. But that's not the case for the "version" key, you can have a profile without "version".

So if you install a profile without the version key, the $info = \Drupal::service('extension.list.module')->getExtensionInfo($profile); will handle this and set the $info['version'] to NULL(which avoid the error of this issue), but on the screen the user will see something like:

Do you think we need to handle the cases where the "version" key is empty?

FYI: If you wanna test this issue you can install a new drupal 9.3 instance with the "minimal" profile instead of the standard. Then open core/profiles/minimal/minimal.info.yml file and remove the "version" key.

Per #15, I'm moving this to "Closed (cannot reproduce)". Thanks!