Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Field should use "native" prefix so no need in core patches
Comment | File | Size | Author |
---|---|---|---|
#8 | 2480201-8.patch | 3.45 KB | erik.erskine |
Comments
Comment #1
andypostAlso better to inherit jsonb
Comment #2
erik.erskine CreditAttribution: erik.erskine commentedjson
isn't a valid generic type according to the schema API, nor a valid MySQL type. However I don't see a reason why this module can't store the serialised string as text on non PostgreSQL databases.As above, the MySQL type isn't valid here. We can probably remove the MySQL specific line and default to the generic
text
type.Comment #3
kevinquillen CreditAttribution: kevinquillen commentedMySQL JSON has implemented a JSON type as of MySQL JSON 5.7.7. It reads like their implementation is the combination of both JSON/JSONB from Postgres.
It is only a labs release right now. When will it be merged into the main MySQL branch, I am not sure.
Comment #4
andypostAlso MariaDB 10.0.16 supports that
So probably we need to add check for db version in
hook_requirements
and readme update tooComment #5
kevinquillen CreditAttribution: kevinquillen commentedWill do.
I suspect we will need a way to implement JSON specific query altering as well? Or should we leave that to developers just wanting to store the data? Might be quite useful to work in Views support at the least.
Comment #6
kevinquillen CreditAttribution: kevinquillen commentedComment #7
kevinquillen CreditAttribution: kevinquillen commentedI haven't forgotten about this. I am trying to get MySQL version selection into my VM build so I am not limited to just Postgres.
Comment #8
erik.erskine CreditAttribution: erik.erskine commentedRerolled #1, because FormatterBase::viewElements function has changed.
Comment #9
andypostMysql should do a version check, but could be expensive
Comment #11
kevinquillen CreditAttribution: kevinquillen commentedPatch has been applied and pushed to dev for review
Comment #12
kevinquillen CreditAttribution: kevinquillen commentedandypost & erik, are we good here in 8.1.x?
Comment #13
andypostI'm OK with current code, and still waiting for beta1
Suppose db version check needs separate issue, just to display warning if unsupported version used with suggestion to upgrade to minimal version to get speedup
Comment #14
andypostFiled #2793899: Add hook_requirements() about minimum suggested version
Looking for beta release