PostgreSQL: Fix broken migrate table creation

1. +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
   @@ -43,6 +43,13 @@ class Schema extends DatabaseSchema {
   +   * A list of field types that support NOT NULL or NULL modifier.
   +   *
   +   * @var array
   +   */
   +  protected $modifier_supported = array('varchar', 'character', 'int', 'real', 'smallint', 'bigint', 'double precision', 'numeric');
   +
   +  /**
   
   @@ -291,7 +298,7 @@ protected function createFieldSql($name, $spec) {
   -    if (isset($spec['not null'])) {
   +    if (isset($spec['not null']) && in_array($spec['pgsql_type'], $this->modifier_supported)) {
   

   Is this bit needed? The tests don't seem to be failing because of null/not null, and declaring a column of type text not null is valid.

2. +++ b/core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
   @@ -280,7 +287,7 @@ protected function createFieldSql($name, $spec) {
   -    if (in_array($spec['pgsql_type'], array('varchar', 'character', 'text')) && isset($spec['length'])) {
   +    if (in_array($spec['pgsql_type'], array('varchar', 'character')) && isset($spec['length'])) {
   

   This looks good, because text may not have a length limit according to http://www.postgresql.org/docs/9.1/static/datatype-character.html#DATATYPE-CHARACTER-TABLE

Revised the patch in #1 so that it only removes the length modifier for text.

Oops, trying again:
Revised the patch in #1 so that it only removes the length modifier for text.

I was talking with migrate folks, and I think we would need to fix the database script in d6 and d7 as well. Also moving this to migration system component to get more visibility. We still have the issue relationship back to the parent and tag for PostgreSQL.

Sorry for the confusing comment. I think I meant to write that database dump script should be fixed when dealing with issues like #2477857: PostgreSQL: Fix not null constraint exceptions in migrate_drupal tests or #2477853: PostgreSQL: Add support for reserved field/column names. I wanted to add component as migration system. #246962: controlling what shows in "recent posts' menu item seems to have fixed the process for creating database dumps so that we are not reliant on the database scripts, and are just using a SQL file to do so, right?

I think @ingaro's patch is fine, and all that's left to do is a confirmation of test results for migration tests.

Committed and pushed to 8.0.x. Thanks!