Problem/Motivation

BasicSyntaxTest fails currently with PostgreSQL as database backend. The cause is commit of #2454669: SQLite: Fix tests in migrate_drupal test group where a new test is introduced that makes use of getFullQualifiedTableName(). Unfortunately getFullQualifiedTableName() is currently broken for PostgreSQL and returns the wrong full table identifier.

Proposed resolution

Fix getFullQualifiedTableName().

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#2 2477251.patch925 bytesamateescu

Comments

bzrudi71’s picture

bzrudi71 commented
Assigned: Unassigned » bzrudi71
Issue summary: View changes
amateescu’s picture

amateescu commented
Title: PostgreSQL: Fix system\Tests\Database\BasicSyntaxTest » PostgreSQL: Fix Connection::getFullQualifiedTableName()
Status: Active » Needs review
StatusFileSize
new 2477251.patch925 bytes

Nice, the test added in #2454669: SQLite: Fix tests in migrate_drupal test group discovered that getFullQualifiedTableName() is broken on PostgreSQL too :/ Not really surprised by this since that method was not tested or used anywhere until migrate_drupal had a use-case for it.

Implement getFullQualifiedTableName() in PostgreSQL driver space to just return the pure table name.

We still have to return the fully qualified table name, not just the (pure) table name alone because that method is used when we're doing a query on a different database.

Can you please try this patch? Completely untested on my system because I'm too lazy to re-install D8 on PG at the moment, but it should do the trick.

I'm pretty sure this will fix #2356985: PostgreSQL: Fix tests in migrate_drupal test group too.

bzrudi71’s picture

bzrudi71 commented

LOL, I was just in this minute going to ping you for feedback on this :-) Will try that in the next hours especially curios about the migrate_drupal tests. Thanks!

bzrudi71’s picture

bzrudi71 commented
Assigned: bzrudi71 » Unassigned
Priority: Major » Critical
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Great! As expected we have pass locally and on PG bot with patch applied! I don't like the hardcoded 'public' schema but thats out of scope for this issue and will be addressed in #1060476: Multiple issues when PostgreSQL is used with non-public schema.
Raising to critical to get more attention as this is a hard blocker for further work on #2356985: PostgreSQL: Fix tests in migrate_drupal test group.
Thanks @amateescu!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 62e182f and pushed to 8.0.x. Thanks!

  • alexpott committed 62e182f on 8.0.x 
    Issue #2477251 by amateescu: PostgreSQL: Fix Connection::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.