Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Apr 2015 at 15:40 UTC
Updated:
21 Jul 2015 at 10:25 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboximfaber2477133git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
manjit.singhYou might want to change the git-command. You can do this by unchecking the checkbox next to "Maintainer", on the Version Control-tab of your module-page. Also resolve pareview issues.
Comment #3
ziomizar commentedHi imfaber,
Thanks for your module.
GIT
You have to set a default branch in your repository and fix the git command in the issue description
README
Your README.txt dont have a Table of content and the installation sections.
USAGE
In Administration » Configuration » User interface » HTML Sucker Blocks i have a form with any description, i follow my intuit to fill all the fields to create a block.
When i go to the Structure >> block i found the new block and set it in a region of the site.
When i go to the home page i get an error
Fatal error: Call to a member function find() on a non-object in /var/www/.../public_html/sites/all/modules/html_sucker/html_sucker.module on line 84Now i should come back to the configuration page to solve the problem, but i have no idea of what the fields means, and the front page of the site is not working. I have to uninstall your module to restore the site.
SUGGESTION
I have seen that your module do a request to the external resource every time that the page is called, what about a cache system to store the result?
Comment #4
ziomizar commentedsorry this is a duplicated
Comment #5
imfaber commentedHi ziomizar,
thanks for your review.
That error occurs when the HTML cannot be fetched for any reason but once it is fetched it will be stored in DB therefore you should have a single request per block.
I thought I'd handled that error but apparently not very well.
I'll try to make the form more descriptive as well.
What do you mean by "sorry this is a duplicated"?
Comment #6
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.