Short Description
Scald Extra adds some extra useful functionality related to the Scald module ecosystem.

Details
Currently it provides the following functionality to module users:

* Automatically generate scald contexts for image styles that render the atom as its image only. This is useful for being able to easily render an atom image in the desired image style when referencing an atom in a node view mode or embedded in text on a WYSIWYG editor.

* Pre-generate thumbnails for image styles when uploading an image for an atom. This can help prevent performance issues when a lot of images are uploaded, and to avoid problems that happen sometimes with the thumbnails not being generated until the next time the cache is cleared.

Sandbox
https://www.drupal.org/sandbox/krystalcode/2475707

Git
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/krystalcode/2475707.git scald_extra

Pareview
http://pareview.sh/pareview/httpgitdrupalorgsandboxkrystalcode2475707git

Comments

krystalcode’s picture

Issue summary: View changes
krystalcode’s picture

Title: Scald Extra project application » Scald Extra
Issue summary: View changes
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manjit.Singh’s picture

Status: Needs review » Needs work

Provided git link is not worked, Please correct this. We are not able to clone your module for code review.

krystalcode’s picture

Issue summary: View changes

Hi @Manjit.Singh,

I have reformatted the link to use the http protocol. The previous link would work if you would be using ssh keys.
Let me know if you still have issues.

Cheers

krystalcode’s picture

Status: Needs work » Needs review
vineethaw’s picture

Status: Needs review » Needs work

Hello,

hook_help() is missing in this module.It would be nice to add it.
And there is no "Configure" link for the module.You can add it in the module's ".info" file, using the "configure" key.

krystalcode’s picture

Status: Needs work » Needs review

Hi @vineethaw,

Thanks for the feedback. I have implemented hook_help and I have added the configure property in the .info file.

Cheers

chenderson’s picture

Automated Review

Seems like parareview.sh is insisting on spaces for your @Issue when you have two in one function
http://pareview.sh/pareview/httpgitdrupalorgsandboxkrystalcode2475707git

Manual Review

README.txt/README.md

I notice you have already made some changes to the README.txt however being a bit picky you could change a little bit to match the template here https://www.drupal.org/node/2181737

Also for easier maintenance you could change your hook_help() to load in your README.txt file instead of have two places to update. See https://www.drupal.org/node/161085#hook_help

Apart from that everything seems to be working. Confirmed that all the images styles generate before viewing and that the option for only numeric image styles to generate works as expected.

krystalcode’s picture

Hi @chenderson, thanks for the comments.

Regarding the @Issue annotation, this looks like a Code Sniffer bug. Same type annotations should go together without a separate line between them. From the API documentation and comments standards page (https://www.drupal.org/node/1354#order):

"Separate different-type sections by a blank line (for instance, all the @param documentation goes together, with a blank line before the first parameter and a blank line after the last parameter before the @return section starts)"

I've updated the README.txt file to better match the suggested template.

I prefer to have a separate version for the hook_help. I know it needs a bit extra maintenance but there are sections that serve a purpose in the file but not so much on the help page e.g. the Contents Of This File section, Maintainers, or even the Installation section.

Torvald’s picture

Hi krystalcode,

I have reviewed your project.
Please see my findings below:

  • Please add [D7] tag to title
  • You need to fix some of the problems found by the pareview

Thanks!

ajalan065’s picture

Title: Scald Extra » [D7]Scald Extra

Hi krystalcode,
I have not gone through the functionality of your module. Just took a brief look at your project and found some issues.
1. Your project has not been yet reviewed and fixed as a full project. Hence it has not yet obtained the url either http://drupal.org/project/scald_extra or http://drupal.org/project/issues/scald_extra. It would give you error 404 if you try out these links.
2. No need to mention the php version in your *.info file. Drupal has the required version of php to run your module.
3. Fix the Pareview issues.
4. Instead of empty() in *.module, use isset() function. Its more recommended over empty() and efficient too.

ajalan065’s picture

Status: Needs review » Needs work
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.