Problem/Motivation

In #2193693: Improve theme description and screenshot alt-text for usability: we discussed the tags for drupal themes, and we couldn't find how they are used by Drupal.org.

As core themes set examples and expectations for other themes, including unused tags set an expectation for others to use tags, even if they have no use.

Proposed resolution

Remove tags from all core themes

Remaining tasks

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, minor cleanup.
Issue priority Normal because it's dead code.
Prioritized changes Not a prioritized change.
Disruption Not disruptive, this is just removing dead code.

User interface changes

None

API changes

None

CommentFileSizeAuthor
#3 remove_tags_from_all-2471619-3.patch607 bytesjeanfei

Comments

lewisnyman’s picture

Title: Remove tags from all core theme info.yml » Remove tags from all core theme.info.yml files
lewisnyman’s picture

Component: Bartik theme » theme system
jeanfei’s picture

Status: Active » Needs review
StatusFileSize
new607 bytes

I've removed the "tags" line in seven theme which was the only one with tags information.

fabianx’s picture

Assigned: Unassigned » star-szr

I am okay with that change if we don't use the tags anywhere, assigning to Cotter for final sign-off.

star-szr’s picture

Assigned: star-szr » Unassigned
Status: Needs review » Reviewed & tested by the community

Hmm…

So I ran:

git log -S "multi-column, fluid, responsive, sans-serif, accessible"

Which led to #2193691: New methods, standards for describing Seven themes admin page.

From the issue summary there:

tags: (new .info property) Tags would match up with a new taxonomy vocabulary for themes on Drupal.org. If you clicked on a particular tag, then a lightbox would show up with Drupal.org download links for themes that matched that tag (i.e., like how things work for installing themes in WordPress). This would mean that you could click single-column, monochromatic, recolorable, multi-column, fluid, fixed, etc. and see what other themes had that characteristic.

I don't think even if that was implemented on d.o it should be source from the .info file. Themes on d.o by definition are nodes, and can have a term reference field.

So I'm in favour of removing this metadata since it is not being used and IMO should not be used.

star-szr’s picture

Issue summary: View changes

Adding beta evaluation.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 3a85c89 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 3a85c89 on 8.0.x
    Issue #2471619 by jeanfei: Remove tags from all core theme.info.yml...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.