Its been a long time since the README was updated. Module and its configuration has changed a lot and it needs to be updated.

CommentFileSizeAuthor
#15 interdiff-2471579-15.txt2.05 KBsanja_m
#15 2471579-15.patch5.36 KBsanja_m
#13 interdiff-2471579-13.txt4.2 KBsanja_m
#13 2471579-13.patch4.2 KBsanja_m
#6 entity_embed-readme_update-2471579-6-D8.patch3.5 KBsnehi
#4 entity_embed-readme_update-2471579-4.d8.patch1.83 KBsnehi

Comments

slashrsm’s picture

slashrsm commented
Issue tags: +Media Initiative, +sprint, +Novice
slashrsm’s picture

slashrsm commented
Issue tags: -sprint +D8Media
snehi’s picture

snehi commented
Assigned: Unassigned » snehi
snehi’s picture

snehi commented
Status: Active » Needs review
StatusFileSize
new entity_embed-readme_update-2471579-4.d8.patch1.83 KB

Please review patch.

Status: Needs review » Needs work

The last submitted patch, 4: entity_embed-readme_update-2471579-4.d8.patch, failed testing.

snehi’s picture

snehi commented
StatusFileSize
new entity_embed-readme_update-2471579-6-D8.patch3.5 KB

Please review attached patch.

snehi’s picture

snehi commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: entity_embed-readme_update-2471579-6-D8.patch, failed testing.

Status: Needs work » Needs review

snehi queued 6: entity_embed-readme_update-2471579-6-D8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: entity_embed-readme_update-2471579-6-D8.patch, failed testing.

Status: Needs work » Needs review

snehi queued 6: entity_embed-readme_update-2471579-6-D8.patch for re-testing.

sanja_m’s picture

sanja_m commented
Assigned: snehi » sanja_m

Reviewing.

sanja_m’s picture

sanja_m commented
StatusFileSize
new 2471579-13.patch4.2 KB
new interdiff-2471579-13.txt4.2 KB

Updated README.md

slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work

Few comments:

  1. +++ b/README.md
@@ -2,45 +2,38 @@
-### Embed by UUID (recommended):
-```html
-<div data-entity-type="node" data-entity-uuid="07bf3a2e-1941-4a44-9b02-2d1d7a41ec0e" data-view-mode="teaser" />
-```

    I'd leave this info in but update it to reflect latest situation (using instead of a

    , data-view-mode being deprecated in favour of data-entity-embed-display and data-entity-embed-display-configuration, ...).

    Maybe create a new section "Embedding entities without WYSIWYG" or something similar. 

  2. +++ b/README.md
@@ -2,45 +2,38 @@
-### Embed by ID (not recommended):
-```html
-<div data-entity-type="node" data-entity-id="1" data-view-mode="teaser" />
-```

    Same as above. 

  3. +++ b/README.md
@@ -2,45 +2,38 @@
-### Display Plugins
-```html
-<div data-entity-type="node" data-entity-id="1" data-entity-embed-display="entity_reference:entity_reference_entity_view" data-entity-embed-settings='{"view_mode":"teaser"}' />
-```
-
-A more advanced use for embedding entities uses an entity embed display plugin, provided in the `data-entity-embed-display` attribute. By default we provide four different display plugins out of the box:
-

    Same as above.

sanja_m’s picture

sanja_m commented
Status: Needs work » Needs review
StatusFileSize
new 2471579-15.patch5.36 KB
new interdiff-2471579-15.txt2.05 KB

Added "Embedding entities without WYSIWYG" section.

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Committed. Thank you both!

  • slashrsm committed 70cb11d on 8.x-1.x authored by sanja_m 
    Issue #2471579 by sanja_m, snehi: Update README.md

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2628150: Update README & .info.yml description