The default list of devices is showing its age; the newest device on the list -- the iPhone 5 -- was released 2012. We should update this list to reflect a more current set of devices, at the very least to acknowledge how much the market has moved towards devices with larger screens.

Tests should be updated to match as well.

CommentFileSizeAuthor
#5 responsive_preview-new-devices-2469617-5.patch4.52 KBsamuel.mortenson

Comments

eatings’s picture

eatings
he/him
Primary language English
Location San Francisco, USA
commented
Category: Feature request » Task
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented

Proposed new list of devices, to replace the existing list (small/medium/large will be unchanged):

  1. iPhone 6
  2. iPhone 6+
  3. iPad Air 2
  4. iPad Mini 3
  5. Nexus 9
  6. Nexus 6
  7. Nexus 5

These are the currently advertised products from Google and Apple, and represent a nice range of screen sizes. I omitted iPhone 5* products as they are probably going to reach EOL this year, and this keeps us future-proof.

eatings’s picture

eatings
he/him
Primary language English
Location San Francisco, USA
commented

iPads have the same effective viewport dimensions so Air and mini distinctions are moot. Let's remove an iPad, add a more mainstream Android device?

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented

We could just remove iPad and keep Nexus 9, which is a mainstream tablet that has a common viewport dimension.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new responsive_preview-new-devices-2469617-5.patch4.52 KB

Updated device list and tests (which were failing in the first place, but now match the current devices).

Status: Needs review » Needs work

The last submitted patch, 5: responsive_preview-new-devices-2469617-5.patch, failed testing.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs work » Needs review
eatings’s picture

eatings
he/him
Primary language English
Location San Francisco, USA
commented

Hmm, going to have to fix those tests soon. Changes look good to me, though. Adding to 7.x-1.x.

eatings’s picture

eatings
he/him
Primary language English
Location San Francisco, USA
commented
Status: Needs review » Closed (fixed)