Unable to trigger onLoad on checkbox type on edit atom properties

The workaround i found is to make the showHideOptions function available globally by the patch attached.

And then to add in the setup:

                 setup: function(widget) {
                    Drupal.dndck4.registeredOptions.push({id: this.id, type: 'image', mode: 'atom', name: 'scald_image'});
                    Drupal.dndck4.showHideOptions(this);

Then it works fine. (Though in certain cases then the showHideOptions will be called twice.

@gifad : can you check if you see the same thing? If we can do this workaround, or rather should do something else?

@gifad thats not going to work on pages where you have more than one wysiwyg.
The dialog add runs when you click on the edit atom properties (and thats when all the other js runs that adds new items).
So clicking edit atom properties in the first field will add correctly the 2 items (scald_image, and my custom), and then if you do the same in the second wysiwyg, it will add them too, and you end up having 4 items in the Drupal.dndck4.registeredOptions

So in fact the current version of the code works fine, cause even though it always replaces the array with an empty one and fills it up again in each wysiwyg, but since we dont have the capability to add something different for a specific wysiwyg it wont cause a problem.

a) I think that at this point:
+ if (found = (this.id == id && this.type == type && this.mode == mode && this.name == name)) {
Checking the id would be enough, as likely you would not give the same id to two different items.

b)
$.merge(Drupal.dndck4.registeredOptions, [item]);
I dont see why we need merge as we will never add more than one item at the same time, so the previous push is enough.

a) Hmm well since here we only add to the list to have a list to consider when doing a cycle.
So if the field is the same on another provider, then that provider does not need to add the option, as it will be added by the other provider for the image already.
Or even if the other provider adds it to the list, comparing the id would be enough, as then one of the providers will add the item to the list.
If both provider is supposed to display its field on the atom properties, then they should not have the same id anyways, so that case would be fine as well.

So can you provide a use case where comparing only with the id would be bad?

Okey.

Another question. In showHideOptions it seems unnecessary to do $.each 3 times. Seems to me that what the function does could be done with a single $.each, as you are not accessing any other items in an iteration.
Also lets delete the commented console logs at the end.

Thanks!

Committed.