Problem/Motivation

The Test recently failed after some caching settings in D8 were changed. We have to make the test pass again.

Proposed resolution

Add cache tags to cached objects.

Remaining tasks

None

User interface changes

None

API changes

None

CommentFileSizeAuthor
#2 pollCachingFix_2468215_1.patch2.71 KBLKS90
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
pollCachingFix_2468215_1.patch2.71 KB

A patch that fixes the Test. The caching settings were removed (As D8 already sets that up now) and cache tags added so the test works as expected.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks good, there's tons of stuff to clean up in those tests, but this is enough for now.

We no longer need to enable caching that is done by default now in core.

  • Berdir committed 0a5186f on 8.x-1.x authored by LKS90 
    Issue #2468215 by LKS90: Test fails due to caching error
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

huh?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.