Problem/Motivation
The latest version of oa_core makes calls to oa_core_get_titles passing 0 as the $limit parameter. This causes file titles to disappear from the treeview widget. I believe the intention is to retrieve all titles.
Proposed resolution
Rather than need to send in magically large values, let a value of 0 or NULL return all values.
Remaining tasks
None known
User interface changes
None known
API changes
Any code making a call to this function with a 0 limit parameter intentionally to retrieve no results will suddenly receive results. I believe this is acceptable as I can see no side effects from this function that would cause someone to want to call it without getting the results back.
Comment | File | Size | Author |
---|---|---|---|
#1 | oa_core-unlimited_titles-2464845-1.patch | 537 bytes | tekante |
Comments
Comment #1
tekante CreditAttribution: tekante commentedComment #2
mpotter CreditAttribution: mpotter commentedComment #3
hefox CreditAttribution: hefox commentedHad theis exact change sitting in my local uncommited XD Sorry about that