Problem/Motivation

The feedback message administration overview uses a custom theme implementation, but the markup can be achieved with the default form rendering. This has multiple benefits:
- Less custom code to maintain.
- The form can be altered with additional columns and data.

Proposed resolution

Let's remove the custom theme implementation, so the administration overview form can be properly altered.

Remaining tasks

  1. Write a patch
  2. Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 feedback-remove_custom_admin_overview_theme-2462931-1.patch6.81 KBidebr

Comments

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new feedback-remove_custom_admin_overview_theme-2462931-1.patch6.81 KB

Attached patch removes the custom theme implementation for the admin feedback messages overview.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

I think this page is mostly deprecated because the newer admin page uses Views. Do you not have Views enabled or do you prefer this form for some reason?

idebr’s picture

idebr commented

I noticed there was a view after I had already finished some custom code for the overview. Considering Views is in core in Drupal 8 and it is present on virtually every Drupal 7 site, Feedback could probably add a dependency to Views and remove the custom admin overview altogether?

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Needs review » Closed (outdated)

Most of the code modified in this patch has no real equivalent in the 3.x version.

The Drupal 7 version of Feedback is no longer available, and no longer maintained. (If you'd like to maintain the Drupal 7 version, please post an issue in the queue)

So I'm going to close this issue as outdated.

Thanks in advance for your patience and understanding as I try to clean up this project's issue queue!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.