We've removed all the usages of Utility\String but there are still plenty of use statements, lets remove those now so we can start testing on PHP 7.

Also, we should do an audit of unused use statements in core, there are heaps!

CommentFileSizeAuthor
#3 remove_string_use-2462151-3.patch11.1 KBhussainweb
#3 interdiff.txt678 byteshussainweb
remote-string-use.patch10.43 KBbenjy

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +PHP 7.0 (duplicate)

The patch only removes use statements and all tests pass.

Thanks!

benjy’s picture

benjy commented
Parent issue: » #2454439: [META] Support PHP 7
hussainweb’s picture

hussainweb
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff.txt678 bytes
new remove_string_use-2462151-3.patch11.1 KB

There is another reference. Removing it.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

Just a comment. Back to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Part of the PHP7 critical - could be done as part of the class removal but doing it now keeps things simple. Committed ea08182 and pushed to 8.0.x. Thanks!

  • alexpott committed ea08182 on 8.0.x 
    Issue #2462151 by hussainweb, benjy: Remove unused Utility\String use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.