The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.There are no tests to ensure that password expiration e-mails work properly.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | password_policy-7.x-1.x-add_expire_warning_email_tests-2461665-14.patch | 9.12 KB | aohrvetpv |
Comments
Comment #1
aohrvetpv commentedComment #2
aohrvetpv commentedInitial attempt at tests for expiration e-mails. Starting with 7.x-1.x because I would like to have these tests to ensure no regressions when working on some expiration-related 7.x-1.x bugs.
This patch requires first applying the patch in #2467941: Mock time retrievals for testing.
Code will need some refinement.
Comment #3
aohrvetpv commentedComment #7
aohrvetpv commentedRemove extra blank line in patch context.
Comment #9
aohrvetpv commentedTests pass on my local system. This patch adds an effective debug print to hopefully identify why the tests are failing on Testbot.
Comment #11
aohrvetpv commentedSuspect timing issue where Testbot executes so fast that the time does not advance one second as is assumed by the test. This patch attempts to test that hypothesis.
Comment #13
aohrvetpv commented- Add one second to times tested to avoid Testbot failure. This is more correct anyway, because the warning e-mail says the user's password will expire "in less than X days", not "in X days or less".
- Update comments to be more precise about times.
Comment #14
aohrvetpv commentedRemove word from comment for consistency.
Comment #16
aohrvetpv commentedCommitted since this is needed as a basis for adding tests for #2464779: 7.x-1.x using D6-style tokens.
Comment #17
aohrvetpv commented6.x-1.x is no longer supported.