Closed (fixed)
Project:
Drupal.org customizations
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Mar 2015 at 21:36 UTC
Updated:
19 May 2018 at 08:09 UTC
Jump to comment: Most recent
Comments
Comment #1
yesct commentedComment #2
yesct commentedComment #4
drummWork on this has started, see https://sa-drupal.dev.devdrupal.org/node/2757532
Comment #5
drummI committed the refactoring changes to the
devbranch. On devwww, I made a2461167-sabranch, committed what was there so far, and merged indev. The diff is quite a bit smaller now.Reusing the version field from issues won't work well. The field base config keeps track of single/multivalued fields, so this forces issues to have multiple values for versions: https://sa-drupal.dev.devdrupal.org/admin/structure/features/drupalorg_s.... While that's something we might want to do, #66484: Allow issues to be filed against multiple versions/branches., that comes with a bunch of other work. Something like #1347438: Reverting Features Drops Search API DB tables is probably where all the issues went on that dev site.
The versions field value population is somewhat abstracted out, using this little module https://www.drupal.org/project/dereference_list.
Comment #7
tvn commentedI looked around on sa-drupal dev site, a few things:
1. It looks like node titles are generated automatically, the one I saw was:
"Drupal core - Security risk: 12/25 ( Moderately Critical) AC:Basic/A:User/CI:Some/II:None/E:Proof/TD:All - XSS - SA-contrib-201"
This should be much shorter, can we only take 'Moderately Critical' part of the security risk field value?
2. It would be nice if Project: [title] would link to the project page
3. Published date is not currently displayed in any way
4. Content type could use a description on /node/add
It would be nice if the issue summary could be updated with more details about the planned content type. E.g. where and how it would be used and displayed (are there issues about creating views to display listings of SAs?), user permissions (I assume only 'security team' role and admins will be able to create it?), will SA be displayed in any way on related projects, what are the planned url patterns for these, etc. etc.
The view of SAs should be a logical part of the Security section, so would be nice to discuss building those while keeping the overall Security section in mind. Where there any email notifications planned for the new content type? By making it a group content inside of Security section, we get those for free (users can follow Security section and get notifications of all new nodes created in it).
Comment #8
tvn commentedComment #10
drummI made a few improvements over the last couple weeks:
Comment #14
drummI think I fixed up everything from #7, and pushed an export of the feature.
To do:
Comment #16
mlhess commentedVersion field should use dereference_list to get version numbers from the project, or add help text for correct formatting.
Is now done and on the branch, but I forgot the issue number in the commit
Comment #22
drummPSAs are now done by selecting the “securitydrupalorg” project. This autogenerates a title without the project name or security risk, matching recent PSAs. If promoted to the home page, up to the first 150 characters of the description are included, in line with the usual promoted blog posts.
Remaining work:
Comment #23
drummI started on the PSA View at https://sa2-drupal.dev.devdrupal.org/admin/structure/views/view/drupalor.... The “Content: Has taxonomy term” filter is causing an
INNER JOIN {taxonomy_index}instead ofLEFT JOIN, so the test PSA on the site isn’t found. Hopefully a different filter works better.Comment #24
kattekrab commentedHey @drumm - any updates or progress on this one?
Or - more specifically - anything any of us can do to help?
Comment #25
drummI think this round of work is actually good to launch. Then we can:
I think I might do the initial launch on a Saturday since I fully expect it to degrade site performance for 10 minutes.
Comment #27
drummFinally did the initial deployment. In addition to #25, we also need to set the permissions on staging and export that Feature.
Comment #29
drummSecurity team members can now create and edit SA content
Comment #30
drummMoving #25 into the issue summary along with the additional work I found.
Comment #31
drummComment #33
drummDeployed a few fixes today:
Comment #35
drummI added the Contact & more info block.
Comment #37
drummThe new content type is now in use: https://www.drupal.org/sa-contrib-2017-077
Updating the issue summary with some followups:
The email did not go out, but that was due to mis-moderation. It will go out with tomorrow’s SAs.
Comment #38
drummThe Coordinated by field is now the last field to be displayed.
Comment #41
john morahan commentedI think the new content type is missing from the dashboard block view (http://cgit.drupalcode.org/drupalorg/tree/features/drupalorg_security_ad...)
Comment #43
drummJohn Morahan - thanks, that has been corrected now.
The new content type is being used with success. It is probably time to open followup issues for the remaining tasks and close this issue.
Comment #44
drummFiled followup issues for the remaining to dos:
#2969694: Streamline SA publishing
#2969695: Migrate old security advisories to SA content type
Mission accomplished.
Comment #45
kattekrab commentedThanks @drumm - nice work here.