Problem/Motivation

Due to a bug in the Icon API (#2434441: Overridden bundles should only store overridden properties) and when this module changed the render hook used in #2312935: [fontawesome] 7.x-2.x, some users may have a database entry of Font Awesome in the {icon_bundle} table. This inadvertently "caches" the entire bundle, which is not needed.

Proposed resolution

Provide an update hook that looks for this database entry and re-save it so only the overridden properties are actually stored.

Remaining tasks

  • Create a patch

User interface changes

None

API changes

None

Comments

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Related issues: +#2312935: [fontawesome] 7.x-2.x
truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Active » Postponed (maintainer needs more info)

I am sorry for no one has replied to you before now.

The post seems a bit old. So I was wondering what the current status is? Do you wish to solve it or is it outdated now? Otherwise, do you have any suggestions for a patch which can work with icon-module?

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

It is a notification to let you know that we are closing the issue as we have not received a response from you for a while.

If you have any further questions, answer or still experiencing regarding this issue then please reply to this issue and choose the status such as active.

Thank you in advance!

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Assigned: Unassigned » markhalliwell
Status: Closed (outdated) » Active

This probably still needs to happen at some point.

FWIW, I am also a maintainer and this was more of a "todo" for me.

I'll get to it when I get to it.

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented

Hi @markcarver,

Sure, no problem at all! ;)

I am happy to leave it open. Let me know if there is something we can help you from here! :)

Otherwise, I have a question if it is possible to change the category to Task? However, it is up to you since I am not so familiar with the bug here.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Title: Provide an update hook for Icon API integration » [PP-1] Provide an update hook for Icon API integration
Category: Bug report » Task
Status: Active » Postponed

The bug is technically in the Icon API, so yes... I suppose this should be a task once that is finished.

Also, marking as postponed on that issue.

Daniel.Moberly’s picture

Daniel.Moberly CreditAttribution: Daniel.Moberly commented
Status: Postponed » Closed (outdated)