Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Mar 2015 at 14:41 UTC
Updated:
13 Apr 2015 at 09:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
andypostComment #2
andypostComment #3
andypostComment #4
prateekMehta commentedMoving all usages of String::decodeEntities() to Html::decodeEntities()
replacing Drupal\Component\Utility\String::decodeEntities() Drupal\Component\Utility\Html::decodeEntities() or
Adding Drupal\Component\Utility\Html::decodeEntities() wherever required.
Comment #5
prateekMehta commentedComment #6
dawehnerThis looks great, let's see whether it passes.
Comment #8
prateekMehta commentedHad accidentally used
Drupal\Component\Utility\Htmltwice in a couple of files,removing it.
Comment #9
prateekMehta commentedComment #11
prateekMehta commentedReplacing at a few other places,sorry for negligence.
Comment #12
prateekMehta commentedComment #13
dpopdan commentedLooks good to me, just please remove decodeEntities() from Drupal\Component\Utility\String.
Comment #14
ajitsRemoving the deprecated function as suggested in #13.
Comment #15
dpopdan commentedThanks !
Comment #16
alexpottLet's remove this in a separate issue. Makes rollbacks and managing the rtbc queue easier. Also please attached this issue to the change record.
Comment #17
alexpottIn fact we should should have a single issue to remove the string class that will go in after all the conversions are done.
Comment #18
hussainwebI believe that was what was in patch in #11. Uploading here again. Setting to RTBC. Updating change record at https://www.drupal.org/node/2457593.
EDIT: Fixed link to change record.
Comment #19
hussainwebCreated follow up at #2458387: Remove Utility\String class.
Comment #20
berdirChanging parent, so all these issues are visible in the php7 meta issue.
Comment #21
webchickUnsurprisingly, this needs a re-roll after #2457887: Use Utility\SafeMarkup class instead of Utility\String for placeholder(), checkPlain(),format() functions.
Comment #22
kim.pepperDidn't get any merge conflicts in re-roll. Was that expected?
Comment #24
kim.pepperHelps if I update 8.0.x first. :-(
Comment #25
stefan.r commentedYou may have forgotten to pull? :)
Let's see if this passes tests...
Comment #27
stefan.r commentedComment #28
andypostChecked, all converted and no "use" left
Comment #29
alexpottThis should be critical since it's parent task is. Committed f3b8d07 and pushed to 8.0.x. Thanks!