Hi.

I have faced rare problem on some pages. Links to nodes rendered fine on preview, but was broken on page.

Right version

Broken links

CommentFileSizeAuthor
#1 freelinking-broken_nodetitle_links-2456647-1.patch6.13 KBAlexKirienko
Selection_070.png50.5 KBAlexKirienko
Selection_069.png40.48 KBAlexKirienko

Comments

AlexKirienko’s picture

AlexKirienko commented
Status: Active » Needs review
StatusFileSize
new freelinking-broken_nodetitle_links-2456647-1.patch6.13 KB

I have find out source of problem. Such broken links was saved in static cache, but cache was not used. 

function freelinking_nodetitle_nid_from_title(&$target) {
...
$node_cache_title = &drupal_static(__FUNCTION__, array());
...
}

I have fixed this issue and refactor two functions:
freelinking_nodetitle_callback($target, $plugin)
freelinking_nodetitle_nid_from_title(&$target)

Please check attached patch.

AlexKirienko’s picture

AlexKirienko commented
Issue summary: View changes

  • gisle committed 6750372 on 7.x-3.x authored by AlexKirienko 
    Issue #2456647 by AlexKirienko: Fixed broken nodetitle links
AlexKirienko’s picture

AlexKirienko commented
Status: Needs review » Fixed

Thank you.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Fixed » Needs review

So far, it is only pushed to to the 7.x-3.x-dev branch, so it is not fixed in a stable release yet.

And I want it reviewed by some more members of the community (i.e. not only the author of the patch) before moving to RTBC.

When it gets to RTBC, I push a tagged release and change Status to "Fixed".

AlexKirienko’s picture

AlexKirienko commented

I see. Sorry.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Version: 7.x-3.x-dev » 7.x-3.6
Status: Needs review » Fixed

This is now fixed in version 7.x-3.6 of Freelinking.

Note: Before updating to version 7.x-3.6, you should to enable the following module on your site: Advanced help hint.

Also, as part of updating, make sure you run the update script to make sure this required module is properly enabled.

Failing to do so will trigger the following error message when you try to visit some of the tabs in the admin GUI: Call to undefined function advanced_help_hint_docs() ...

AlexKirienko’s picture

AlexKirienko commented

Great, thank you. I will test new version soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.