Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Mar 2015 at 10:53 UTC
Updated:
7 Apr 2015 at 21:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
benjy commentedComment #2
benjy commentedComment #3
benjy commentedComment #4
dawehnerLet's see who picks this up
Comment #5
mpdonadiompdonadio goes back and rereads the proposed solution, so this can be ignored.
Comment #6
baisongWill someone take a look at the annotations? I'm unsure when to add underscores vs simply concatenating the new prefixes to the ids.
Comment #7
tim.plunkettAll of the @file lines need to be updated too
Comment #8
dawehner@baisong
Note: you can make the patch much smaller by using a better git configuration, see "Optimize diffs for renamed and copied files"
on https://www.drupal.org/documentation/git/configure
What does the bot say?
Comment #9
catchBumping to critical, this needs to happen before 8.0.0
Comment #10
rteijeiro commentedFixed.
Comment #12
dawehnerI think we could fix things properly while we are here.
Comment #13
rteijeiro commentedSorry for being such stupid for you @dawehner, but that's not the way to treat people when you want to attract people to contribute to Drupal. I'll omit also your comment in IRC because I know you personally but this can be misunderstood by people that don't know you or me.
Let's see I now my patch seems less stupid for you than the other one ;)
Comment #14
dawehnerI'm sorry but it was really not meant like that. I'll be serious from now on.
Comment #15
tim.plunkettThe last patch was not rolled against updated HEAD. It has a bunch of recent commits in there too.
Comment #16
mpdonadioSetting back to needs work b/c the diff included way too much, as Tim also mentioned. Maybe you pulled and didn't rebase?
If these files are being touched, that per https://www.drupal.org/node/1354#file, this should be changed to
and so on for each class that got renamed. I got dinged on this today...
Comment #17
rpayanmLet me try :)
Comment #20
dawehner@rpayanm You seemed to have missed these changes.
Sorry for the nitpicks ...
Comment #21
rteijeiro commentedSorry for the crappy patch in #13. I hope this one is better.
@dawehner thanks for the reviews ;)
Comment #22
dawehnerI hope things are alright again ... it was not intended to be cruel or something like that.
It looks great now!
Comment #23
rteijeiro commentedNo problem, buddy! We'll have a beer at #drupaldevdays ;)
Comment #24
hussainwebI think we missed out null from here: https://wiki.php.net/rfc/reserve_more_types_in_php_7. Working on a patch now.
Comment #25
hussainwebRenaming
NulltoNullArgument.Comment #26
hussainwebUpdating IS for the new class.
Comment #27
dawehnerGood catch!
It would be great if we could update the docs here, similar to the other examples.
Comment #28
hussainwebDone
Comment #29
dawehnerAwesome, thank you
Comment #30
alexpottThis issue addresses a critical bug and is allowed per https://www.drupal.org/core/beta-changes. Committed e5d6c14 and pushed to 8.0.x. Thanks!
Comment #32
tr commentedDoesn't this at least deserve a change notice? This broke a lot of my code over the weekend...
Comment #33
mpdonadioAnybody can make CR. I just published one for this issue: #2458383: Views plugin classes renamed to support PHP 7
Comment #34
tr commentedThank you. I know anyone can do it, but it should be done as part of the process, in conjunction with the commit, otherwise we are left with hundreds of changes with no documentation of the change. It's very frustrating porting D7 to D8, or even D8 from two months ago to D8 today, when everything breaks and there is no mention of the change anywhere. This is especially bad with anything Views related, because it's poorly documented to begin with.
Comment #35
dawehnerSo please help and don't just complain!
Comment #36
tr commentedI was explaining, not complaining. And I have been helping for years, in case you haven't been paying attention ...
Comment #37
dawehner@TR
Yeah no offence to you, I was more referring to the general complaining in the Drupal community,
which pisses me off a lot. Believe me, but I won't work on core at 1am at the night.