The commit in #2000934: Allow selection of which folder a file is to on the file/add form adressed a critical issue where media_internet related modules like media_youtube or media_vimeo became unusable with the following PHP error:

The specified file youtube://v/fSed_FPXWrI could not be copied, because the destination directory is not properly configured. This may be caused by a problem with file or directory permissions. More information is available in the system log.
EntityMalformedException: Missing bundle property on entity of type file. in entity_extract_ids() (line 7766 of includes/common.inc).

In the next comment, I will post a patch that fixes this problem!

CommentFileSizeAuthor
#1 php_exception_after-2454823-1.patch657 byteshctom

Comments

hctom’s picture

hctom
Primary language German
commented
StatusFileSize
new php_exception_after-2454823-1.patch657 bytes

... and here is the corresponding patch

hctom’s picture

hctom
Primary language German
commented
Status: Active » Needs review
hctom’s picture

hctom
Primary language German
commented
Issue summary: View changes
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Priority: Critical » Major

Downgrading priority as this isn't a problem for users not using Media.

hctom’s picture

hctom
Primary language German
commented

... okay... but doesn't this also affect every file entity using a non writable or remote stream wrapper?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Fair enough, but it's still not critical. Critical issues imply that the module is useless for everybody. See Priority levels of issues.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks for catching & fixing it!

broeker’s picture

broeker commented

Note that there is a competing patch, and both seem to fix the same issue with a slightly different tack:

https://www.drupal.org/node/2443059

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#2000934: Allow selection of which folder a file is to on the file/add form

#2000934: Allow selection of which folder a file is to on the file/add form has been reverted.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

see patch #30 from #2000934: Allow selection of which folder a file is to on the file/add form