Replace comment_username handler with generic views handler

Working on this at Drupal4Gov code sprint Co-Sponsored by Forum One ;)

This issue is critical as per parent issue.

Let's remove the assignment, as it might block people from working on it.

ehem, nearly.

Did we really need a special formatter for this? I would think the standard formatters that were previously available would have worked. What options/formatting was missing?

Did we really need a special formatter for this? I would think the standard formatters that were previously available would have worked. What options/formatting was missing?

The feature, which is not provided is the special logic for the anonymous user. For them, we get the username from the manually entered
username in the comment form, there is simply no formatter for that yet.

Thank you @geertvd!

I think we will need a test though ... :)

1. +++ b/core/modules/comment/config/schema/comment.views.schema.yml
   +++ b/core/modules/comment/config/schema/comment.views.schema.yml
   @@ -82,9 +82,6 @@ views.field.comment_username:
   
   @@ -82,9 +82,6 @@ views.field.comment_username:
      type: views_field
      label: 'Node comment status'
      mapping:
   -    link_to_user:
   -      type: boolean
   -      label: 'Link this field to its user or an author''s homepage'
   

   Ideally we should remove the full entry of views.field.comment_username

2. +++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/AuthorNameFormatter.php
   @@ -0,0 +1,46 @@
   +    foreach ($items as $delta => $item) {
   +      $account = entity_create('user');
   

   Note: #2454163: Replace comment_username handler with generic views handler should better use those tools.

3. +++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/AuthorNameFormatter.php
   @@ -0,0 +1,46 @@
   +      $account->uid = $item->getOwnerId();
   +      $account->name = $item->getAuthorName();
   +      $account->homepage = $item->getHomepage();
   +      $elements[$delta] = array(
   +        '#theme' => 'username',
   +        '#account' => $account,
   +      );
   

   Note: Also this code should probably not always create an issue, but instead use the author if the author is not the anonymous one.

4. +++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/AuthorNameFormatter.php
   @@ -0,0 +1,46 @@
   +}
   \ No newline at end of file
   

   It would be great to add a newline.

Thanks for the help, this one actually works :)

1. Removed
2. Not sure what you mean here
3. Done
4. Done

I'll work on some tests next.

1. +++ b/core/modules/comment/src/CommentViewsData.php
   @@ -33,7 +33,8 @@ public function getViewsData() {
   +    $data['comment_field_data']['name']['field']['id'] = 'field';
   

   I think the default is field, so this line can go

2. +++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/AuthorNameFormatter.php
   @@ -0,0 +1,50 @@
   + * Plugin implementation of the 'user_name' formatter.
   

   should be the ID, i.e. 'comment_username'?

Working on tests

My first patch in over a week...

Think we need cache tags too?

And we need to limit the availability.

Patch could have conflict with related

1. +++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/AuthorNameFormatter.php
   @@ -0,0 +1,62 @@
   +      $account = $comment->getOwner();
   +      if ($account->isAnonymous()) {
   +        $account->setUsername($comment->getAuthorName());
   +        $account->setEmail($comment->getAuthorEmail());
   +        $account->homepage = $comment->getHomepage();
   +      }
   

   Can we add a todo for the issue I linked in the different comment?

2. +++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/AuthorNameFormatter.php
   @@ -0,0 +1,62 @@
   +  public static function isApplicable(FieldDefinitionInterface $field_definition) {
   +    return $field_definition->getName() === 'name';
   +  }
   

   IMHO we should also check for the entity type.

Can we add a todo for the issue I linked in the different comment?

Which issue are you referring to? You linked to this ticket in #12

Ehem sorry, #2458817: Creating new user entities for anonymous users is very slow is it.

comment_prepare_author can be replaced with $comment->getOwner() when #2458817: Creating new user entities for anonymous users is very slow is fixed again.
Added the check for entity type.

Awesome, do you mind adding a follow up for replacing that, once the other issue is in?

Note: this does not need tests:

+class CommentUserNameTest extends ViewUnitTestBase {

I think CommentViewsFieldAccessTest needs updating to cover this too - see #2462589: Provide test coverage for access checking of all views fields.

#2458817: Creating new user entities for anonymous users is very slow just got fixed so we should replace comment_prepare_author with $comment->getOwner() in this ticket.

Addressed #27 (I guess) and #28.

In indeed does!

This issue addresses a critical bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 6a7d1bb and pushed to 8.0.x. Thanks!