Renderer::getCacheableRenderArray() does not include max-age

I think we miss some test coverage here, but yes straight follow-up.

Updated tests for the patch

Missed a few cases in past patch

+++ b/core/tests/Drupal/Tests/Core/Render/RendererBubblingTest.php
@@ -114,6 +114,7 @@ public function providerTestContextBubblingEdgeCases() {
+          'max-age' => -1,

@@ -142,6 +143,7 @@ public function providerTestContextBubblingEdgeCases() {
+          'max-age' => -1,

@@ -165,6 +167,7 @@ public function providerTestContextBubblingEdgeCases() {
+          'max-age' => -1,

@@ -251,6 +256,7 @@ public function providerTestContextBubblingEdgeCases() {
+          'max-age' => -1,

@@ -339,6 +345,7 @@ public function testConditionalCacheContextBubblingSelfHealing() {
+        'max-age' => -1,

@@ -362,6 +369,7 @@ public function testConditionalCacheContextBubblingSelfHealing() {
+        'max-age' => -1,

@@ -393,6 +401,7 @@ public function testConditionalCacheContextBubblingSelfHealing() {
+        'max-age' => -1,

@@ -417,6 +426,7 @@ public function testConditionalCacheContextBubblingSelfHealing() {
+        'max-age' => -1,

@@ -432,6 +442,7 @@ public function testConditionalCacheContextBubblingSelfHealing() {
+        'max-age' => -1,

@@ -447,6 +458,7 @@ public function testConditionalCacheContextBubblingSelfHealing() {
+        'max-age' => -1,

+++ b/core/tests/Drupal/Tests/Core/Render/RendererPostRenderCacheTest.php
@@ -92,6 +92,7 @@ public function testPostRenderCacheWithColdCache() {
+        'max-age' => -1,

@@ -228,6 +229,7 @@ public function testRenderChildrenPostRenderCacheDifferentContexts() {
+        'max-age' => -1,

@@ -323,6 +325,7 @@ public function testRenderChildrenPostRenderCacheComplex() {
+        'max-age' => -1,

@@ -349,6 +352,7 @@ public function testRenderChildrenPostRenderCacheComplex() {
+        'max-age' => -1,

@@ -463,6 +467,7 @@ public function testPlaceholder() {
+        'max-age' => -1,

@@ -561,6 +566,7 @@ public function testChildElementPlaceholder() {
+        'max-age' => -1,

@@ -589,6 +595,7 @@ public function testChildElementPlaceholder() {
+        'max-age' => -1,

@@ -620,6 +627,7 @@ public function testChildElementPlaceholder() {
+        'max-age' => -1,

Should these be 0 instead of -1? In the #2443073: Add #cache[max-age] to disable caching and bubble the max-age issue I saw that setting these to 0 was effectively saying don't cache them.

That should be Cache::PERMANENT instead, which is == -1;

So, replace -1 with Cache::PERMANENT instead?

#14; Okay, understood. It sets the value of max-age to Cache::PERMANENT by default instead of hardcoded -1, should've checked that before. Thanks!

Nice work, RTBC.

This is just a straight bug fix that was overseen from a previous issue.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed cc54a48 and pushed to 8.0.x. Thanks!