If you put more than one fivestar fields to a content and all fields has different tags and one vote is accepted per fivestar fields, you can only vote one of them. So you can't vote to the others in the same content.

i.e.: there are 3 fields, which called: vote1, vote2, vote3 on the same content (content type) with different tags and you allow only one vote per fields ("Allow users to re-vote on already voted content." unchecked at vote1, vote2 and vote3). Then you vote to vote2, vote1, vote3. After page refresh you can see, only the vote2 had been saved and you can't vote to vote1 and vote3.

Patch included.

CommentFileSizeAuthor
#23 fivestar-single_vote_multiple_tag-2451173-23-D7.patch566 bytesgolddragon007
#4 test_result.JPG139.13 KBgolddragon007
#1 fivestar-single-vote-multiple-tag-2451173.patch564 bytesgolddragon007
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 commented
Issue summary: View changes
FileSize
fivestar-single-vote-multiple-tag-2451173.patch564 bytes
golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: fivestar-single-vote-multiple-tag-2451173.patch, failed testing.

golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 commented
Status: Needs work » Needs review
FileSize
test_result.JPG139.13 KB

With the included test file my patch passes... why was this failed?

golddragon007 queued 1: fivestar-single-vote-multiple-tag-2451173.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: fivestar-single-vote-multiple-tag-2451173.patch, failed testing.

pp queued 1: fivestar-single-vote-multiple-tag-2451173.patch for re-testing.

The last submitted patch, 1: fivestar-single-vote-multiple-tag-2451173.patch, failed testing.

pp’s picture

pp CreditAttribution: pp commented
Version: 7.x-2.1 » 7.x-2.x-dev

Change version number, because testboot not downloads votingapi module.

pp queued 1: fivestar-single-vote-multiple-tag-2451173.patch for re-testing.

pp’s picture

pp CreditAttribution: pp commented
Status: Needs work » Needs review
golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented
dbt102’s picture

dbt102 CreditAttribution: dbt102 commented
Status: Needs review » Needs work
golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented

@dbt102: Could you explain what's the problem?

dbt102’s picture

dbt102 CreditAttribution: dbt102 commented

looks like the patch failed testing

more info about that can be found here --> https://www.drupal.org/node/1058140

golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented
Status: Needs work » Needs review

retest

golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented
Status: Needs review » Needs work
golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented

Well I think it was passed, because of "PASSED: [[SimpleTest]]: [MySQL] 118 pass(es)." message at the patch (triggered by #10 comment). But I don't know how can I send this to retest it.

dbt102’s picture

dbt102 CreditAttribution: dbt102 commented

maybe try retooling the patch and submitting it again?

doco on that is here -->

https://www.drupal.org/project/fivestar/git-instructions

golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented
Version: 7.x-2.x-dev » 7.x-2.2
golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented
Version: 7.x-2.2 » 7.x-2.x-dev
Status: Needs work » Needs review
golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented
Status: Needs review » Needs work

well I can't do it right now, I don't have time for that... I will try it later on my local machine, the simple test and apply the patch to the current version and I will share the result here

golddragon007’s picture

golddragon007 CreditAttribution: golddragon007 at Brainsum commented
Status: Needs work » Needs review
FileSize
fivestar-single_vote_multiple_tag-2451173-23-D7.patch566 bytes

Refresh patch. (remove hunk, and try a retest)

dbt102’s picture

dbt102 CreditAttribution: dbt102 commented

Nice job on getting the patch to pass @golddragon007 ... now needs review/comment and/or testing by others

gg24’s picture

gg24 CreditAttribution: gg24 as a volunteer and at QED42 commented
Assigned: golddragon007 » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi @golddragon007, @dbt102

I have tested patch #23 and it applies cleanly and works as expected.

Testing steps:

  1. Created new tags for fivestar from "admin/config/content/fivestar"
  2. Created three fivestar fields to article content type
  3. Unchecked "Allow users to re-vote on already voted content" for all three fields.
  4. Created a content for above mentioned content type.
  5. Voted for only one field, lets say "Vote 1"
  6. Refreshed the page and checked. It didn't allow me to vote for unvoted fields before applying the patch.
  7. After applying patch, it allows me to vote.
  8. Hence patch works as intended.

Issuing RTBC to it.

Thanks!

  • dbt102 committed 2680904 on 7.x-2.x authored by golddragon007 
    Issue #2451173 by golddragon007: Single vote on multiple tag per node
dbt102’s picture

dbt102 CreditAttribution: dbt102 at Pineshore commented
Status: Reviewed & tested by the community » Fixed

thanks all for the patch, testing and perseverance

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.