When using Scald with Fieldable Panels Panes, and using the Panels IPE to add or edit panes, the Panels IPE modal overlaps/blocks out the DND Library which renders adding images useless. Wasn't sure whether to patch Panels IPE and it's z-index or Scald Dnd and it's z-index, but figured others might need use of this too.

CommentFileSizeAuthor
#1 scald-fix-for-z-index-2449181.patch420 bytesdremy

Comments

dremy’s picture

StatusFileSize
new420 bytes
nagy.balint’s picture

Status: Needs review » Reviewed & tested by the community

Hi!

I finally got a site with IPE enabled to check this.

For me it seems that lightbox, colorbox, and qtip has a much larger z-index, so this patch would not interfere with those.

What this patch would achieve is that the DND library would always be above the ctools modals.

However since the library can be closed, i dont think its an issue.

Generally its nice to have the dnd always there and useable, like on normal pages as well.

I put this as RTBC.

nagy.balint’s picture

Status: Reviewed & tested by the community » Needs review

@jcisio
Do you see any problem with committing this?

I think the only issue it could cause if someone by accident presses one of the link in the dnd while doing something else in an already existing modal, and then since there can be only one modal, progress can be lost.
Seems like its not a big issue, and could solve the z-index problems for good.

gifad’s picture

Whatever value you commit in dnd-library.css, it will be overriden by scald_gallery.js !
You have been warned !

[Edit] sorry, didn't notice scald_gallery issue DND Library Wrapper floats under Panels IPE modal

nagy.balint’s picture

Yes, it was already considered.

We have to decide about this one first though.

gifad’s picture

Generally its nice to have the dnd always there and useable,

Yep, this makes it easy to drop another atom in whatever textfield/textarea (caption, notice, description,...) the currently created/edited atom may have ...
It will put a hard stress on ckeditor later (what ? nested widgets ?), but I'm working on a patch for that ;-)

jcisio’s picture

#3 Yes I don't think the library floating over our own modal a big problem. It is even expected when we want to search with the library while having a modal open.

nagy.balint’s picture

Status: Needs review » Fixed

Okey then, committed.

  • nagy.balint committed a9f9c4f on 7.x-1.x authored by dremy
    Issue #2449181 by dremy, nagy.balint: DND Library Wrapper floats under...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.