Remove ._ thumbnal files generated by Mac.

CommentFileSizeAuthor
#8 sharethis-remove-dot-underscore-files-2448791-7.patch4.71 KBbdone
#6 sharethis-remove-dot-underscore-files-2448791-6.patch1.36 KBbdone

Comments

ShareThis Support’s picture

ShareThis Support commented

Hi,

Please elaborate your query, so that we can further assist you.

ram4nd’s picture

ram4nd commented

What part of the sentence don't you understand?

ShareThis Support’s picture

ShareThis Support commented

"Remove ._ thumbnal files generated by Mac." Exactly from where do you want us to remove the files?
Please elaborate exactly what issue you are facing.

ram4nd’s picture

ram4nd commented

As the issue said from code in branch 7.x-2.x-dev. I can place here a link from source tree where you can see these junk files, that should not be there, committed to the git.

http://cgit.drupalcode.org/sharethis/tree/img?id=ce32760

amaisano’s picture

amaisano commented

These files are by default hidden if you're developing on Mac, so @ShareThis_Support, you may not see them unless you expose hidden files or use terminal to list all of the module folder contents. Looking forward to having these removed as well.

bdone’s picture

bdone commented
Status: Needs work » Needs review
StatusFileSize
new sharethis-remove-dot-underscore-files-2448791-6.patch1.36 KB

Attaching a patch to remove these files.

Status: Needs review » Needs work

The last submitted patch, 6: sharethis-remove-dot-underscore-files-2448791-6.patch, failed testing.

bdone’s picture

bdone commented
Status: Needs work » Needs review
StatusFileSize
new sharethis-remove-dot-underscore-files-2448791-7.patch4.71 KB

re-rolled. this time using git format-patch --binary --full-index.

ShareThis Support’s picture

ShareThis Support commented

Hi There,

Thanks for your patience here! We've made some changes in our support organization and we're working through responding to these. We appreciate the patch and submitted it as a request to our engineering team. Please let us know if you have any additional questions!

Best
ShareThis Support

andrewmacpherson’s picture

andrewmacpherson commented
Status: Needs review » Reviewed & tested by the community

Tested the patch from #8. Straightforward, does what the issue needs.
Confirmed that it removes all ._*.png from img/ directory, none remain after the patch.

purushotam.rai’s picture

purushotam.rai commented
Related issues: +#2240223: Remove git and trash files from repository
purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Fixed

hi,

Solving #2240223: Remove git and trash files from repository issue also fixes this issue. Thanks to all for all your input. We really appreciate your work.

Marking this issue as fixed. Feel free to re-open if issue still persists.

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.