Closed (won't fix)
Project:
DrupalCI: Environments
Component:
PHP Containers
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Mar 2015 at 17:18 UTC
Updated:
5 Jul 2020 at 00:07 UTC
Jump to comment: Most recent
Comments
Comment #1
cilefen commentedComment #2
cilefen commentedComment #3
cilefen commentedComment #4
chx commentedI think there should be a category of bots which check only per commit, more in an advisory than in a mandatory capacity and this should be one of them. I would even argue that the non-mysql bots should be too.
Comment #5
cilefen commented@chx I agree. In a case like this, the non-bytecode cached test runners would be a waste of time to test every patch.
Comment #6
cilefen commentedComment #7
dawehnerIdeally we would have some static analysis tools which would cover the particular problem mentioned. Does someone know of such a tool?
Comment #8
catchSo I think running every patch would be a complete waste.
Running post-commit would be useful enough.
A bonus might be running the additional environments when a patch reaches RTBC.
Comment #9
cilefen commentedComment #10
jthorson commentedChoosing which environments run is a job at the dispatch level.
This issue, however, is about ensuring we have a non-opcode test runner that the dispatch can route tests too. How best do we do this within the test runner?
Options:
- separate test type for non-opcode testing? (yuck)
- disable_opcode flag in the test definition? (Need to explore how best to disable it ... if we have steps, we can build this into the test-runner logic, possibly as a pre-execute command/script)
- other?
Comment #11
chx commentedphp.ini chunks in the job yaml?
Comment #12
jthorson commentedHmmm ... a 'setup: php:' plugin, which takes php.ini chunks as a value, which adds those chunks to the ini file and restarts PHP before executing actual tests would work ... at least an idea worth exploring further.
Comment #13
MixologicComment #14
MixologicComment #15
elachlan commentedMoved to DrupalCI Environments.
Comment #16
MixologicPostponing on https://www.drupal.org/node/2607876
Comment #17
MixologicIm going to go ahead and close this. opcode caching is available in all supported versions of php by default, so I dont think this is a scenario we need to test for.