See #2407361: Move usages of drupal_html_id() to Html::getUniqueId().

There is a PHP bug on class importing that is hidden when using bytecode caches.

Comments

cilefen’s picture

cilefen’s picture

Issue summary: View changes
cilefen’s picture

Title: Need tests runners without bytecode caching » Need test runners without bytecode caching
chx’s picture

I think there should be a category of bots which check only per commit, more in an advisory than in a mandatory capacity and this should be one of them. I would even argue that the non-mysql bots should be too.

cilefen’s picture

@chx I agree. In a case like this, the non-bytecode cached test runners would be a waste of time to test every patch.

cilefen’s picture

Issue summary: View changes
dawehner’s picture

Ideally we would have some static analysis tools which would cover the particular problem mentioned. Does someone know of such a tool?

catch’s picture

So I think running every patch would be a complete waste.

Running post-commit would be useful enough.

A bonus might be running the additional environments when a patch reaches RTBC.

cilefen’s picture

jthorson’s picture

Choosing which environments run is a job at the dispatch level.

This issue, however, is about ensuring we have a non-opcode test runner that the dispatch can route tests too. How best do we do this within the test runner?

Options:
- separate test type for non-opcode testing? (yuck)
- disable_opcode flag in the test definition? (Need to explore how best to disable it ... if we have steps, we can build this into the test-runner logic, possibly as a pre-execute command/script)
- other?

chx’s picture

php.ini chunks in the job yaml?

jthorson’s picture

Hmmm ... a 'setup: php:' plugin, which takes php.ini chunks as a value, which adds those chunks to the ini file and restarts PHP before executing actual tests would work ... at least an idea worth exploring further.

Mixologic’s picture

Issue tags: +drupalci_environments
Mixologic’s picture

Component: Code » Environments
elachlan’s picture

Project: DrupalCI: Test Runner » DrupalCI: Environments
Component: Environments » Code

Moved to DrupalCI Environments.

Mixologic’s picture

Mixologic’s picture

Status: Postponed » Closed (won't fix)

Im going to go ahead and close this. opcode caching is available in all supported versions of php by default, so I dont think this is a scenario we need to test for.