I apologize for not having the correct terminology to describe this -- I'm not a themer.
The <div id="toolbar-administration"> element sits to the right of the visual location of that element when the toolbar is docked on the left of the viewport. The result is you are unable to click on elements under this ghost
Note: this requires the toolbar to be on the left-side of the screen (works correctly when docked at the top) and only seems to be an issue on the admin/content/files page.
Sorry for the lousy bug report -- only had a few minutes.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | toolbar_admin.png | 542.6 KB | malcomio |
| #6 | Files___s66e87dd2a810783_s3_simplytest_me.png | 696.61 KB | lewisnyman |
| #2 | 2446663-2.patch | 607 bytes | idebr |
| toolbar-covers-admin-contennt-files.png | 180.48 KB | mikeker |
Comments
Comment #1
idebr commented@mikeker Thanks for submitting this bug report! I was able to reproduce this issue on /admin/content/files.
After an initial investigation the issue seems to be caused by the contextual links region styling on the body element that exists on the Files administration page, but not on the Content administration page.
Comment #2
idebr commentedThis appears to be an issue with the Toolbar rather than Seven. This CSS was introduced in #1860434: Refactor the Toolbar JavaScript to use Backbone; fix several poorly functioning behaviors comment #48 without much explanation, so needs manual testing in different browsers to test nothing broke.
Comment #3
mikeker commentedVerified it fixes the issue reported -- I haven't done any testing beyond that so I'm not moving it to RTBC. I'll leave that to someone that better understands front-end CSS... :)
Thanks, @idebr, for finding the root cause!
Comment #4
lewisnymanI had a look over the CSS to find the intentions of the code and I couldn't see a good reason for it. I also tested the patch in multiple browsers with no regression. Thanks!
Comment #5
alexpottSo this only is happening on
admin/content/filesand notadmin/contentoradmin/content/comment- how come? I think something else is wrong.Comment #6
lewisnyman@alexpott Of course! You're right, on the content/files page 'position: relative' is added to the body tag which is not good...
Comment #7
idebr commentedRe: @alexpott in #5
Views has an advanced option 'Contextual links' that is enabled for admin/content/files but not for admin/content. While inconsistent, either option is valid.
Re: @Lewis Nyman in #6
Can you elaborate what is 'not good' about it? It's perfectly valid CSS.
Comment #8
lewisnymanRight but if you add this kind of of styling to the body, it's impossible to know if you will be introducing regressions because it's not possible to insert HTML outside of the body tag. I don't think we should every style the body tag directly. Any chance we can add it to a wrapper div or something?
Comment #9
idebr commented@LewisNyman There is an issue in the contextual.module component regarding contextual links for the main page content #1916516: Decide whether/how to implement contextual links associated with the main page content. Does this cover your concern or am I missing your point entirely? :)
Comment #10
lewisnymanYeah it seems like it could solve the problem, but not anytime soon :\
Comment #11
jhedstromThis needs an IS update with remaining tasks. The patch still applies, but doesn't seem to be the agreed-upon resolution.
Comment #12
malcomio commentedI can't reproduce this issue - I assume it must have been fixed elsewhere.