Error trying to clone a variant

Getting the same here.

This was reported in the Panels Everywhere issue queue too: #2422189: Error when cloning a variant

Another related issue, this time for Panelizer: #2445769: Unable to clone a display

I think I may have an idea on this one. The following patch #813754-44: Ability to set variant machine name in Panels UI made some changes to how machine names are handled for tasks. It allows for a name to be passed in from the form instead of automatically generated. On cloning unfortunately the task name is identical to the variant being cloned which triggers the error. I briefly tested the following change to the clone/import code - adding lines 451 to 454 in page_manager.module:

    441 function page_manager_handler_add_to_page(&$page, &$handler, $title = NULL) {
    442   $last = end($page->handler_info);
    443   $handler->weight = $last ? $last['weight'] + 1 : 0;
    444   $handler->task = $page->task_id;
    445   $handler->subtask = $page->subtask_id;
    446   $handler->export_type = EXPORT_IN_DATABASE;
    447   $handler->type = t('Normal');
    448 
    449   if ($title) {
    450     $handler->conf['title'] = $title;
    451     $handler->conf['name'] = preg_replace('/[^a-z0-9_]+/', '-', strtolower($title));
    452   }
    453   else {
    454     $handler->conf['name'] = '';
    455   }
    456 
    457   $name = page_manager_handler_get_name($page->task_name, $page->handlers, $handler);
    458 
    459   $handler->name = $name;
    460 
    461   $page->handlers[$name] = $handler;
    462   $page->handler_info[$name] = array(
    463     'weight' => $handler->weight,
    464     'name' => $handler->name,
    465     'changed' => PAGE_MANAGER_CHANGED_CACHED,
    466   );
    467 }

Essentially this passes in a machine name if the title is available and nothing if a title is not available so that a unique name based on UUID will be created. I briefly tested cloning and importing and they seem to work, however I would like some thoughts or suggestions from others that may know this code a bit better before posting a patch.

I am going to move this to the ctools issue queue (hope that is okay!) since I believe the issue is in the page_manager code and provide a patch for the community to have a look at.

That older project is the wrong one, this is the correct ctools ;)

Trying to trigger the testbot.

Could you please test the latest -dev release, see if the problem persists?

FYI I tested this with the current -dev releases of Panels and CTools and wasn't able to reproduce the problem.

Still hitting this with fresh dev versions of Panelizer, Panels, and ctools.

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'site_template__basic_sidebar_layout' for key 'name': INSERT INTO {page_manager_handlers} (name, task, subtask, handler, weight, conf) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array ( [:db_insert_placeholder_0] => site_template__basic_sidebar_layout [:db_insert_placeholder_1] => site_template [:db_insert_placeholder_2] => [:db_insert_placeholder_3] => panel_context [:db_insert_placeholder_4] => -27 [:db_insert_placeholder_5] => a:12:{s:5:"title";s:20:"Basic Sidebar Layout";s:9:"no_blocks";i:1;s:8:"pipeline";s:8:"standard";s:22:"body_classes_to_remove";s:0:"";s:19:"body_classes_to_add";s:0:"";s:6:"css_id";s:0:"";s:3:"css";s:0:"";s:8:"contexts";a:0:{}s:13:"relationships";a:0:{}s:4:"name";s:20:"basic_sidebar_layout";s:6:"access";a:2:{s:7:"plugins";a:1:{i:0;a:3:{s:4:"name";s:5:"front";s:8:"settings";N;s:3:"not";b:1;}}s:5:"logic";s:3:"and";}s:3:"did";s:2:"18";} ) in drupal_write_record() (line 7261 of /var/www/clients/client0/web28/web/includes/common.inc).

Just to confirm, I am still seeing it too on the latest dev:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'node_view__news' for key 'name': INSERT INTO {page_manager_handlers} (name, task, subtask, handler, weight, conf) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array ( [:db_insert_placeholder_0] => node_view__news [:db_insert_placeholder_1] => node_view [:db_insert_placeholder_2] => [:db_insert_placeholder_3] => panel_context [:db_insert_placeholder_4] => 101 [:db_insert_placeholder_5] =>

The patch still applies on the latest dev and fixes the issue.

Same thing for me as with #15. I'm using Chaos tools 7.x-1.7 and Panels 7.x-3.5 with nothing else. Once I learned how to patch it worked perfectly. Thanks for the fix! ^_^

I've confirmed that this patch resolves the problem for closing Panels Everywhere displays.

#7 Fix issue for me, please commit it.

works for me, cheers.

RTBC++

#7 was working for me, but has since stopped. Has anyone else had the patch stop working? I've tried reinstalling the module and patching it again, but no luck.

Yup, tested this all week, looked good to me!

Oh, thanks a lot. With this bug, the following ugly workarounds were necessary:
http://cgit.drupalcode.org/entity_panels/commit/?id=cf7e65d

The patch doesn't fix the problem of cloning. The clone can have the same title as the original, so the name becomes the same as the original also.

Moreover, when non-English letters are used for variant title, this title transforms into empty name which break cloning again.

@maximpodorov: I suggest creating a new issue for this problem.

FYI in the Panelizer world a patch was added to improve the cloning process: #2480999: Machine name on panlizer clone form doesn't autocomplete

I think this problem can be solved here, it doesn't differ from the original description.

+1

The patch solves the problem by checking new name existence in the DB.

I am getting "PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry..." when cloning a variant. @ maximpodorov is your patch in in #32 in addition to the patch in #7 or instead?

#32 confirmed works. Only #32, not in addition to #7.

#7 is already committed. Patch #32 is for the current dev branch.

This patch worked for me as well and seems pretty reasonable to mark as RTBC given it just checks if name is being used and trims the possibility of the title beginning or ending with a '-'.

Yah this (#32) seems like a decent incremental fix. Done.