EntityMetadataWrapperException: Unknown data property commerce_coupons.

@dpolant it happens only when I create a cart programmatically. No problems with the upgrade/install.

Looks like this needs a re-roll.

I think it only needs a re-roll because there were lots of end of line whitespace errors in the last set of commits.

Re-rolling and slight change to the rules isset() EMW checks.

Used -w flag in git diff because there are lots of ending whitespace issues my editor tries to fix.

@dpolant Any chance you'd consider adding tests? I may be able to write one to show this bug. Setting to priority to normal because I don't see others running into this and it was only my quick programmatically generated cart scripts that were throwing this error.

Ok clean git patch... *shakes fist at testbot*

1. +++ b/commerce_coupon.module
   @@ -1254,9 +1254,6 @@
   -  if (!isset($order_wrapper->commerce_coupons) || !$order_wrapper->commerce_coupons->value()) {
   -    return;
   -  }
   
   @@ -1362,6 +1359,9 @@
   +  if (!isset($order_wrapper->commerce_coupons) || !$order_wrapper->commerce_coupons->value()) {
   +    return;
   +  }
   

   Why does the interdiff show this moved?

2. +++ b/commerce_coupon.rules.inc
   @@ -111,17 +111,17 @@
   +  $has_coupons = $discount_wrapper->coupon_count->value();
   +  ¶
   +  if ($order_wrapper->commerce_coupons->value()) {
   

   nit: Extra whitespace.

3. +++ b/modules/usage/commerce_coupon_usage.module
   @@ -405,7 +405,8 @@ function commerce_coupon_usage_commerce_order_update($order) {
   +      $no_coupons = empty($order->original) || !$unchanged->commerce_coupons->value();
   
   @@ -421,18 +422,20 @@ function commerce_coupon_usage_commerce_order_update($order) {
   +    if (!empty($order->original)) {
   ...
   +  elseif (!empty($order->original) && in_array($unchanged->status->value(), $statuses)) {
   

   What is $order->original? I've not seen that in my travels yet.

@torgosPizza and @id.tarzanych so I'm saying that may be unnessasary for the scope of this issue.

Maybe the interdiff is weird but I don't think those changes are necessary and I can't see anything in #11 that I'd keep. I could be wrong though.

Ok reposting #10 so we can get reviews there. It's fairly quick fix. If the ->original stuff needs to be taken care of maybe it can be in a new issue so this is easier for people to review.

@id.tarzanych feel free to disagree, I'm just trying to finish this issue up to move forward an inch.

Apparently HEAD has moved.

Ensuring all the usages of coupon_count and loops through $order_wrapper->commerce_coupons are checked.

I see a bit more what @id.tarzanych was trying to do. I refactored that a bit to make it a bit more clear to that point (I hope).

+++ b/commerce_coupon.module
@@ -773,16 +773,13 @@ function commerce_coupon_redeem_coupon_code($code, $order, &$error) {
-    foreach ($order_wrapper->commerce_coupons as $order_coupon_wrapper) {
...
+    if (commerce_coupon_order_has_coupon_code($coupon->coupon_id, $order)) {

Also, there was a bit of duplicate logic happening here for checking if a coupon. But I got that wrong. New patch coming a sec. But curious to know if checking the coupon code can be considered the same as checking the coupon_id?

Fixed logic

Whoops, was rushing out the door, apparently I'm not setup to do non-core:P

Now with less patch!