При каждом пересохранении ноды материал заново отправляется в VK дублируясь в записях.

Каждый раз ставить/убирать галочку отправки не могу, так как она для пользователей кто создает материалы недоступна.
Можно ли добавить вариант работы модуля, который позволял бы не создавать пост в VK, если он уже был когда-то создан?

CommentFileSizeAuthor
#6 duplication_posts-2444579-6.patch5.19 KBanpolimus
#4 duplication_posts-2444579-4.patch3.24 KBanpolimus
#3 duplication_posts-2444579-3.patch2.9 KBkala4ek

Comments

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: Unassigned » kala4ek
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Version: 7.x-2.0 » 7.x-2.x-dev
Assigned: kala4ek » Unassigned
Status: Active » Needs review

Created a patch. Now status sending status stored with node info and if node already was posted to VK, checkbox "post it" disabled by default.

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
StatusFileSize
new duplication_posts-2444579-3.patch2.9 KB

Forget to attach patch :)

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
StatusFileSize
new duplication_posts-2444579-4.patch3.24 KB

Hi.
Thanks for your patch. I have reviewed it and it is working properly and is fixing this issue.
There were some issues:
1.

'#default_value' => !$form['#node']->vkxp_sent && variable_get('vkxp_node_enabled_default_' . $form['#node']->type),

were producing warning. I've changed ! to empty().

2. Hook_uninstall produced fatal error. It was not connected with your code, but I've fixed that for making your patch stable.

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented

Only one thing that is seems to be strange (bad UX).
I think, we need to have a separate checkbox, called "Deactivate vk_post checkbox when node has already posted to Vk.com"

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
StatusFileSize
new duplication_posts-2444579-6.patch5.19 KB

I have implemented additional code to your patch with admin interface changes.

Now, at CT admin page, you could add checkbox for preventing double-checking.

  • Anatoliy Polyakov committed 966fb8a on 7.x-2.x 
    git commit -m 'Issue #2444579 by anpolimus, kala4ek: Дублирование...
anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Patch (to be ported)
anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented

Patch has been commited. This pathc would be added to future stable release.

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
Status: Patch (to be ported) » Fixed

Task marked as fixed. This commit would be at 7.x-2.21 version.

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
Status: Fixed » Closed (fixed)