Optionally reduce the number of LinkChecker log entries

Let's add a "Debug mode" or "Verbose logging" setting checkbox to to module and conditional run this watchdog call only if enabled.

Can you share a patch, please?

I didn't review the watchdog severity levels on all 30 or so calls, but this is a really nice way to provide control to the user. It allows users to decide what level to report and only records these to the watchdog() system.

Change in the default level to exclude debugging. About 6 new t() strings.

function linkchecker_watchdog_log($type, $message, $variables = array(), $severity = WATCHDOG_NOTICE, $link = NULL) {
  if ($severity <= variable_get('linkchecker_log_settings', WATCHDOG_INFO)) {
    watchdog($type, $message, $variables, $severity, $link);
  }
}

And usage is as simple as replacing watchdog() with linkchecker_watchdog_log().

-    watchdog('linkchecker', 'Attempted to re-run link checks while they are already running.', array(), WATCHDOG_WARNING);
+    linkchecker_watchdog_log('linkchecker', 'Attempted to re-run link checks while they are already running.', array(), WATCHDOG_WARNING);

Was that a RTBTC?

Excellent, hopefully the maintainer likes it :)

Looks good to me. Commit this after some testing.

I'm personally not going to backport this change as D6 is close to EOL.

Cool, thanks.

Now, (totally out of scope of this issue / project), to write something that combines common watchdog entries, like cron run messages so we can have a watchdog table with months worth of useful messages :)

Hook_watchdog()... A simple task :-)

Hook_watchdog()... A simple task :-)

:P delete x where y

Playing with the idea of writing something that produces a single entry per event, "cron last run w and on x,y,z" and "404 favicon.ico requested 57 times", etc; still fairly easy, just a matter of getting the time to write it :)