Hi,

We're using Webform with Select Or Other, and noticed the text for the "Other" option cannot be translated.

The fix is pretty simple (once you see how). I'll attach a patch once I have an issue id. :)

Cheers

CommentFileSizeAuthor
#1 webform-select_or_other_translation-2442241-1.patch698 bytesmarkus_petrux
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markus_petrux’s picture

markus_petrux CreditAttribution: markus_petrux commented
FileSize
webform-select_or_other_translation-2442241-1.patch698 bytes

  • DanChadwick committed 4586635 on 7.x-4.x 
    Issue #2442241 by markus_petrux: Fixed #translatable property for 'Other...
  • DanChadwick committed ec4bc89 on 8.x-4.x
    Issue #2442241 by markus_petrux: Fixed #translatable property for 'Other...
DanChadwick’s picture

DanChadwick CreditAttribution: DanChadwick commented
Status: Needs review » Fixed

Looks right to me. I don't use translation, so I'm happy to rely on you, given your profile.

Committed to 7.x-4.x and 8.x.

Thank you.

torotil’s picture

torotil CreditAttribution: torotil commented

I've cherry-picked this into 7.x-3.x and it will be part of the 7.x-3.23 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented

Did this fix work? It was reported in #3090285: Make "Other" Label translatable that this doesn't work and a patch there changes the line added in this issue.