Make "Other" Label translatable [#3090285]

Appears like there's a typo in components/select.inc:

When changing

$element['#translatable'][] = 'other';

$element['#translatable'][] = 'other_text';

in line 403, label becomes translatable.

Further change necessary for applying the translated text.

Comment	File	Size	Author
#3	make_other_label_translatable-3090285-3.patch	751 bytes	fjgarlin
#3	7.x-4.x: PHP 7.2 & MySQL 5.5, D7.67 19 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

26 October 2019 at 09:52

thomas.wardin created an issue. See original summary.

Comment #2

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 1 November 2019 at 16:33

Version:

7.x-4.19

» 7.x-4.x-dev

Thanks. Please write up the needed changes as a patch.

File	Size
make_other_label_translatable-3090285-3.patch	751 bytes
7.x-4.x: PHP 7.2 & MySQL 5.5, D7.67 19 pass

Comment #4

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 6 November 2019 at 21:17

The line changed by the patch was added in #2442241: Translatable property for 'Other' option text is missing.

Comment #5

thomas.wardin CreditAttribution: thomas.wardin commented 7 November 2019 at 06:49

Needs the "companion change" in order to work: https://www.drupal.org/project/webform_translation/issues/3075467

Comment #6

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 7 November 2019 at 15:57

I don't understand what is happening here. When I add a select component with the "other" option enabled, there is an "other" form control created. The text "other_text" does not appear in the HTML source.

#2442241: Translatable property for 'Other' option text is missing was about making the "other" label translatable. Presumably, that fix worked for the person who wrote that fix. Does it not work anymore?