Infinity bucle in some cases in ckeditor_file_download

Hi,

i have installed ckeditor in a drupal project with module storage_api, solving an issue with storage api i found some cases where a call to file_download_access can cause infinite calls with other modules interactions.

The code in function ckeditor_file_download, checks that the file is not managed, but first it create the url, than can cause problems (in fact it is doing with storage api), i think that the call to that function can be moved after checking that the file is not managed. It is also more efficient.

This is the actual code:

function ckeditor_file_download($uri) {

  if ($path = file_create_url($uri)) {
  $result = db_query("SELECT f.* FROM {file_managed} f WHERE uri = :uri", array(':uri' => $uri));
  foreach ($result as $record) {
    return NULL;
  }
  //No info in DB? Probably a file uploaded with FCKeditor / CKFinder

I send a patch moving the if after firsts foreach:

function ckeditor_file_download($uri) {
  $result = db_query("SELECT f.* FROM {file_managed} f WHERE uri = :uri", array(':uri' => $uri));
  foreach ($result as $record) {
    return NULL;
  }
  //No info in DB? Probably a file uploaded with FCKeditor / CKFinder
  if ($path = file_create_url($uri)) {

Best
David