panopoly_widgets is doing some magic Javascript to replace Table widgets normal tables with special tables on mobile. This makes it super hard (if not impossible) to implement a site-wide strategy for responsive tables, either in your theme or via a module (like Responsive tables), because panopoly_widgets will be doing its own unique thing for Table widgets - hiding whatever other mechanism you set up.
That, combined with a number of bug in its implementation, like:
- #2432607: panopoly-widgets.css shouldn't mess with ALL tables, just Table widgets
- #2432615: Table widgets simply disappear on mobile without Javascript enabled
Is starting to lead me to believe that panopoly_widgets shouldn't mess around with attempting to implement responsive tables for Table widgets and leave that to other modules or the theme to do on a site-wide basis. Or at the very least, make it easy to disable what panopoly_widgets is doing.
I'm leaning toward the former, and propose just removing it! I'll need to check with the other maintainers first, though.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | panopoly_widgets-no-responsive-tables-2432625-3.patch | 2.5 KB | dsnopek |
Comments
Comment #1
dsnopekOne random note, the 2.x branch on the responsive_tables module is actually a backport of the responsive tables functionality in Drupal 8. If anything, it would seem to fit better with Panopoly's approach to include that module, like we do with navbar and responsive_bartik!
That said, if we went that way, we'd still need to make it an optional dependency, since many themes have their own solution to this problem, and there is really no complete consensus on how responsive tables should be done.
Comment #2
populist commented+1 to using the 2.x branch of the responsive tables module here. the original table code for panopoly was written several years ago when thinking on this wasn't as developed and could absolutely use with updating.
i am also ok with either removing it or restricting it to just the table widget.
Comment #3
dsnopekThanks, Matt!
For now, I think I'm going to remove the responsive tables stuff from panopoly_widgets.
Here's a new issue about adding responsive_tables 2.x to Panopoly:
#2450267: Include responsive_tables 2.x in Panopoly profile (but not as a required dependency)
But we should also be able to get some responsive tables action via Bootstrap in Radix when we merge #1987386: Include Radix theme in Panopoly. So, next steps will take a little more consideration!
Patch is attached which does the removal.
Comment #4
dsnopekCommitted!