Hi there,

I've been using this module for a while now and one thing I like to be able to do is to completely override the CSS and render the feedback module in a different region of the site to make positioning it easier. Ultimately it might be worth creating a block for the feedback form but in the meantime it's easy to add an option for the administrator to override the region used to render the feedback form. Attached is a patch which does just that.

Note that existing installs would be completely unaffected as it will continue to render in page_bottom if no other value has been set.

Would be great to get this patch applied. All feedback welcome of course!

Tom

CommentFileSizeAuthor
#5 interdiff_4-5.txt351 bytesjmuzz
#5 feedback-add_form_block-2432263-5.patch3.07 KBjmuzz
#4 feedback-add_form_block-2432263-4.patch3.06 KBjmuzz
#1 feedback_add_region_choice.patch2.11 KBspecky_rum
feedback_add_region_choice.patch2.15 KBspecky_rum

Comments

specky_rum’s picture

specky_rum commented
StatusFileSize
new feedback_add_region_choice.patch2.11 KB

Patch file (corrects minor error in previously submitted version)

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

This is going in the direction of an imitation block system. It seems like it would make more sense to have an option to not display feedback in its generic way and an option to enable a feedback block (which you would then place via block admin or in panels)

Also regarding different ways to show feedback, have a look at the patch in #693880: Alternative UIs/themes. That's the way I've been customizing its display.

specky_rum’s picture

specky_rum commented

Totally agree that it should be in a block instead. I was just going with the way the module does things at the moment and using a parameter to tweak something that is assumed. It ought to be easy enough to render this in a block, do you think that's worth doing? Would it clash with your work on the related issue?

jmuzz’s picture

jmuzz commented
Title: Add option to render feedback form in different theme region » Add option to render feedback form in a block
StatusFileSize
new feedback-add_form_block-2432263-4.patch3.06 KB

I need this feature too. This patch adds a checkbox to the settings page. When it's active the fixed position form will be replaced by a block called "Feedback form."

It doesn't use the CSS or Javascript that the fixed position form uses. It could be added easily enough, but if it's in a block it's not really a special case anymore and my opinion is the theme can handle it.

jmuzz’s picture

jmuzz commented
StatusFileSize
new feedback-add_form_block-2432263-5.patch3.07 KB
new interdiff_4-5.txt351 bytes

Fixed a warning message that appeared on the blocks page when the option was deactivated.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

Code looks good, just needs testing before committing.

socialnicheguru’s picture

socialnicheguru commented
Status: Needs review » Needs work

no longer applies

ianchan’s picture

ianchan commented

We'd really like to see this available as a block as well. Thanks.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Needs work » Closed (outdated)

Displaying the feedback form as a block is supported in version 3.x.

The Drupal 7 version of Feedback is no longer available, and no longer maintained. (If you'd like to maintain the Drupal 7 version, please post an issue in the queue)

So I'm going to close this issue as outdated.

Thanks in advance for your patience and understanding as I try to clean up this project's issue queue!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.