I am finding that the QueueUI* classes contain duplicated code from the associated queue. Add a reference for the queue instead and use the queue to perform those operations.

Also encapsulate the table name for the QueueUISystemQueue to allow extending the class while overriding the table name.

CommentFileSizeAuthor
#1 2430287-use-queue-reference-1.patch8.13 KBe0ipso
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented
Status: Active » Needs review
FileSize
2430287-use-queue-reference-1.patch8.13 KB
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented

I did this patch while having #2428543: Support namespaced queue classes and queues not based on the `queue` table applied, so maybe this patch depends on the other one. Sorry about the inconvenience.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented

Any way we can move this forward?

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Needs work

This patch doesn't apply. It's created against the wrong folder.