I have a site that uses Submitted By and when looking at the variables listing that Devel provides there are two types of Submitted By variables:

  • submitted_by_[node_type]
  • submitted_by_comment_[node_type]

However, the uninstall function has: variable_del('submitted_by_comment_node_' . $type); which doesn't exist.

Also, what if a content type were deleted prior to uninstalling Submitted By? Then some variables would be left in the database...

CommentFileSizeAuthor
#2 2429963-2.patch4.08 KBtkuldeep17

Comments

tkuldeep17’s picture

tkuldeep17 commented
Version: 7.x-1.x-dev » 7.x-1.0-beta1

Hi bwpanda,

Thanks for raising issue. In beta version, this variable problem does not exist. I have renamed variable.

+1 for raising "if a content type were deleted prior to uninstalling Submitted By? Then some variables would be left in the database." I will create patch for it.

And I am changing version to 7.x-1.x-beta1.

tkuldeep17’s picture

tkuldeep17 commented
StatusFileSize
new 2429963-2.patch4.08 KB

  • tkuldeep17 committed 4a3ad0c on 7.x-1.x 
    Issue #2429963 by tkuldeep17: Remove variable if content type is deleted...
tkuldeep17’s picture

tkuldeep17 commented
Status: Active » Fixed

I have fixed it, and releasing 7.x-1.0 version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.