The D7 project supplies way to put in place a navigation inside content.

It is based on 2 types of fields: one to introduce anchors allowing end users to jump to directly to the content part marked by it, and one allowing to place in the content a menu allowing end users to navigate amongst the different part of the content.

The second field type works by basing on anchors created thanks to the first type.

The fact to base it on fields introduces flexibility in the way to organize this kind of navigation in function of the contribution needs and the type of content.

I made it for different personal projects as I did not find a module offering this kind of feature.
Now, I would like to propose it to the community. Thfact to base it on fields introduces flexibility in the way to organize this kind of navigation in function of the contribution needs and the type of content.

Below, you can find what you need to access the project page and the git repository:

Comments

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjyraya2420769git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

jyraya’s picture

jyraya CreditAttribution: jyraya commented
Assigned: Unassigned » jyraya
jyraya’s picture

jyraya CreditAttribution: jyraya commented
Status: Needs work » Needs review
cfischer83’s picture

cfischer83 CreditAttribution: cfischer83 commented

The proper git clone in your description should be:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/jyraya/2420769.git content_internal_navigation

Adding a new Internal Navigation field to my content type I receive this error:

Notice: Undefined index: _add_existing_field in _content_internal_navigation_remove_field_selection() (line 51 of /Users/coryfischer/Sites/drupal/sites/all/modules/content_internal_navigation/field_ui.admin.inc).

Nit pick, but this should be “an internal” not “a internal”.
A INTERNAL NAVIGATION IS ACTIVATED ON THIS CONTENT

In content_internal_navigation.module in the content_internal_navigation_field_attach_submit function, consider using $form_state['values'] instead of $form_state['input’]. It’s good to avoid raw usage.

Besides that, I feel that it was quite difficult to understand what this module did and how it work. My assumption while reading the README and Project Page was that I could use this inside the editor, or have a field that WAS the editor, just a different type. It took me way too long to understand that the Anchor fields go between my other fields and essentially invisible elements. I would suggest taking a few more detailed screenshots that show multiple anchors between multiple content fields from an admin / display fields view, from the admin / node edit view, then finally from the display output to give people the full context of how this works.

Other than that, things look nice.

cfischer83’s picture

cfischer83 CreditAttribution: cfischer83 commented
Status: Needs review » Needs work
jyraya’s picture

jyraya CreditAttribution: jyraya commented

Thank you very much for the review. I will make the corrections and improvements.

Concerning "In content_internal_navigation.module in the content_internal_navigation_field_attach_submit function, consider using $form_state['values'] instead of $form_state['input’]. It’s good to avoid raw usage.", I used $form_state['input'] because it keeps the correct order of the different anchor fields.

I use it only for the order; then I treat values from $form_state['values] to build internal navigation items.

I do not know how to do it differently; considering that I try to be compliant with Field collection, Paragraphs, and keeping the field treatment performant.

I am open to any suggestions about the question.

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.