Warning: Creating default object from empty value in flickr_request() line 127 flickr.inc.

$result->code = 0;

seems like this line can just be removed!

Or changed to...

$result = array();

CommentFileSizeAuthor
#2 create_default_object_to_avoid_warning_message-2428267-2.patch530 byteslolandese

Comments

webservant316’s picture

webservant316 commented
Issue summary: View changes
lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new create_default_object_to_avoid_warning_message-2428267-2.patch530 bytes

Good catch. I assume you're on PHP 5.4? It slipped through because I still use 5.3 on my local environment.

From http://stackoverflow.com/a/8900730/523688 (with minor edits):

In order to comply with E_STRICT standards prior to PHP 5.4, or the normal E_WARNING error level in PHP >= 5.4, assuming we are trying to create a generic object and assign a keyed value for it, we need to declare $result as an object of stdClass

Attached patch implements the solution given there.

Please, let me know if also this solves your issue in PHP 5.4.

Thanks for reporting.

webservant316’s picture

webservant316 commented

patch works. thanks!

lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community

lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

Committed with attribution as it was pointed out exactly what needed to be changed to solve the issue.

Thanks again.

webservant316’s picture

webservant316 commented

thanks. that might be my first attribution :-) though I am posting suggestions to this forum quite frequently. I just need to get the proper tools to make patches.

have a great day!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.