Problem/Motivation

We want to replace the usages because:

   * @deprecated in Drupal 8.0.x-dev and will be removed before Drupal 8.0.0.
   *   To generate URLs for Drupal routes (that is, most pages generated by
   *   Drupal), see UrlGeneratorInterface::generateFromRoute() instead. For
   *   non-routed local URIs relative to the base path (like robots.txt) see
   *   \Drupal\Core\Utility\UnroutedUrlAssembler.

By using route names consistently, we can avoid needing to change tests if we change route paths

Proposed resolution

Replace path with route names in a Url object when it's pointing to a route

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 remove_calls_to-2425901-6.patch16.9 KBAnonymous (not verified)
#6 interdiff-4-6.txt12.65 KBAnonymous (not verified)
#4 interdiff-2425901-1-4.txt517 bytesmitrpaka
#4 remove_calls_to-2425901-4.patch4.25 KBmitrpaka
#1 2425901-1.patch4.93 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
4.93 KB

Here are some of them removed.

klausi’s picture

Status: Needs review » Needs work

why? please update the issue summary.

dawehner’s picture

Issue summary: View changes
mitrpaka’s picture

pwolanin’s picture

Issue summary: View changes
Anonymous’s picture

I looked into removing some more calls, but I'm wondering whether this approach is ok or not?

Status: Needs review » Needs work

The last submitted patch, 6: remove_calls_to-2425901-6.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: remove_calls_to-2425901-6.patch, failed testing.

pwolanin’s picture

I don't think that's the right approach. We should be giving this a route or URL

r_sharma08’s picture

Issue summary: View changes
r_sharma08’s picture

Assigned: Unassigned » r_sharma08
pwolanin’s picture

pwolanin’s picture

tim.plunkett’s picture

Status: Fixed » Closed (duplicate)