purge_ui.links.task.yml:

system.performance_settings:
  title: 'Performance'
  route_name: system.performance_settings
  base_route: system.performance_settings
purge_ui.core_settings_form:
  title: 'Purge'
  route_name: purge_ui.core_settings_form
  base_route: system.performance_settings

That first one smells very fishy.

CommentFileSizeAuthor
#2 2425093-2.patch468 byteswim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Purge declares 'Performance' task on behalf of system module: smells fishy » [PP-1] Purge declares 'Performance' task on behalf of system module: smells fishy
Status: Active » Postponed
Related issues: +#2425101: system.performance_settings should be declared in system.links.task.yml

Filed a core issue + patch to fix this in core: #2425101: system.performance_settings should be declared in system.links.task.yml.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 2425093-2.patch468 bytes

Patch for when the core issue has been fixed.

nielsvm’s picture

nielsvm commented

Just naively verified that this does indeed depend on #2425101.

nielsvm’s picture

nielsvm commented

This one is still open and so is #2425101, what do you think Wim? Can we close this as 'meh' or do you want to leave it open?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor

You're defining something on behalf of system module. That is something we at least eventually want to get rid of… because that is going to cause problems at some point. Let's demote it to minor?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed » Active

This is now in 8.5

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: [PP-1] Purge declares 'Performance' task on behalf of system module: smells fishy » Purge declares 'Performance' task on behalf of system module: smells fishy
idebr’s picture

idebr commented
Priority: Minor » Normal
Status: Active » Needs review

The task in the Purge UI for the system module results in a duplicate 'Performance' tab now that the System module defines its own task.

nielsvoo’s picture

nielsvoo commented

Indeed, since 8.5 this patch must be reversed. I just did and now only one tab is shown.

Niels

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +purge-3.1

+1 this appears to fix the problem in Drupal 8.9+ I've rerolled the patch in my 3.1 branch.

  • nielsvm committed 3293b6a on 8.x-3.x authored by Wim Leers 
    Issue #2425093 by Wim Leers: Purge declares 'Performance' task on behalf...
nielsvm’s picture

nielsvm commented
Status: Reviewed & tested by the community » Fixed

Merged, thank you for your contributions!

https://www.drupal.org/project/purge/issues/3236847

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.