Problem/Motivation

It's common for performance-related modules to add new tabs to /admin/config/development/performance. Unfortunately, that doesn't work unless that route itself defines a "Performance" tab.

The only way D8 contrib modules can fix this, is by declaring it on behalf of core: #2425093: [PP-1] Purge declares 'Performance' task on behalf of system module: smells fishy. That's not nice. Let's fix that.

Proposed resolution

Declare system.performance_settings in system.links.task.yml. Note that the tab doesn't even show up! So no UI changes. It only shows up if contrib modules declare additional tasks, with this tab as the parent.

Remaining tasks

None.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#9 2425101-1.patch584 bytesmgifford
#1 2425101-1.patch584 bytesWim Leers
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 86,701 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

Wim Leers’s picture

Status: Active » Needs review
FileSize
584 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 86,701 pass(es). View
Wim Leers’s picture

Version: 8.1.x-dev » 8.0.x-dev

Status: Needs review » Needs work

The last submitted patch, 1: 2425101-1.patch, failed testing.

Wim Leers’s picture

WTF, testbot?

FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: failed attempting to get list of tests from run-tests.sh.

Status: Needs work » Needs review

Wim Leers queued 1: 2425101-1.patch for re-testing.

Wim Leers’s picture

Green. Better :)

dawehner’s picture

Does that mean we have to think more about local tasks in general? Doesn't each bit, for example the media parts, have similar problems?

Wim Leers’s picture

It's quite possible this is a more widespread problem. But this seems the only solution for now?

AFAIK this was not a problem in D7. Was it because we declared all of the top-level "admin things" as MENU_LOCAL_TASK, whereas now we have to list all of them "manually" here?

mgifford’s picture

Re-uploading last patch for the bots.

dawehner’s picture

Honestly I don't see that as much of a problem. We can fix core by time and even multiple contrib modules would not really interfere with each other.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jhedstrom’s picture

Anything left to do here? Seems RTBC to me, and if it is more of a widespread issue, follow-ups can be made as @dawehner suggests in #10.

saranya purushothaman’s picture

I think this can move to RTBC. This feature will be useful for other modules, If it moved.

saranya purushothaman’s picture

Status: Needs review » Reviewed & tested by the community

  • catch committed a52185c on 8.5.x
    Issue #2425101 by Wim Leers, mgifford: system.performance_settings...
Wim Leers’s picture

🎉 Created 12 Feb 2015 at 12:40 CET, fixed today, 2.5 years later. Glad we're not just losing sight of these small incremental improvements!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed a52185c and pushed to 8.5.x. Thanks!\n

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.