Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Feb 2015 at 13:39 UTC
Updated:
28 Oct 2015 at 11:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
joekersI'll give this one a go!
Comment #3
pfrenssenI've started on this. I've created a first rough draft of the view and exported it.
Next steps:
Comment #5
pfrenssenI've been working on this today to implement this like it was in Drupal 7, but I changed my mind. I'm now thinking that we should simply clone the existing Content view, since we will gain a lot more functionality than we had (bulk operations! search! filters!) and it will be more consistent with the existing functionality which is a big plus for administrators.
@Jonathan1055, what do you think of this idea? It will look and work like the standard node overview as in the screenshot, but it will have the "Updated" column replaced with two columns "Publish on" and "Unpublish on":
Comment #7
pfrenssen@Jonathan1055, I've implemented the view, is this acceptable for you?
Comment #8
jonathan1055 commentedI think that's an excellent idea and it looks good. Definitely worth having the additional functionality of search, filter and to allow VBO. Couple of questions:
1) I presume, having a brief look at the commit, that the code is all stored in the scheduler file. So it is not like the D7 way of making a new tab using form_alter to clone an existing tab. So that means that if this Core form gets modified, then we should also keep the Scheduler page in line with it. I'm fine with that, but just wanted to check my understanding.
2) Does the admin have the abilty to customise/modify this view or columns displayed? In D7 views you can modify views provided by modules. I don't know if this works the same? Fine if not, again just asking the quesion.
Overall, great work and this is definitely the direction to go.
Jonathan
Comment #9
pfrenssenComment #10
pfrenssenWhat still needs to be done here:
user/{user}/scheduler.admin/config/content/scheduler/list, since this is a duplicate of the one atadmin/content/scheduler. My feeling is that we should remove it to reduce possible confusion.scheduler.routing.yml. I think we should keep the path of the view to beadmin/content/scheduledinstead ofadmin/content/schedulersince this better conveys what is shown on the page: a list of "Scheduled content", rather than a list of "Content managed by the Scheduler module". After all an editor might not even be aware that a module named Scheduler exists on the site.Comment #11
pfrenssenGoing to rebase on top of the latest 8.x-1.x. This will make all commits reappear below this comment in random order.
Comment #14
pfrenssenDid some work on this:
SchedulerListAccess. Now that the custom list of scheduled nodes is gone we do not need to check access to it any more.SchedulerController::listScheduled().scheduler.routing.ymlandscheduler.links.task.yml.What still needs to be done:
Comment #17
pfrenssenCreated a followup task to test access to the scheduled node overviews: #2592293: Test access to scheduled node views. This is now done and merged into 8.x-1.x.