Problem/Motivation

file.formatter.generic.css is only containg theme css so the file name should be named accordingly to our css standards.

Proposed resolution

move the css over so all visual styles are in theme, and only the functional css is inside module.css, following our css standards (MAT) #1887922: [Obsolete] CSS file organization
aka rename file.formatter.generic.css to file.theme.css

Remaining tasks

  1. Write a patch
  2. Review
  3. Include screenshot

User interface changes

None

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because the current file naming is inconsistent with our file naming conventions for CSS
Issue priority Normal because it doesn't fix any bugs or add any features.
Unfrozen changes Unfrozen because it only changes CSS.
Prioritized changes The main goal of this issue is fixing code to our file naming conventions for CSS.
Disruption Not disruptive.

Comments

mortendk’s picture

Title: file module gene » file.formatter.generic.css rename to file.theme.css
mortendk’s picture

Status: Active » Needs review
Issue tags: +Needs screenshots
mortendk’s picture

Component: CSS » file system
idebr’s picture

Status: Needs review » Active

There is no patch attached. Did you forget to upload one? :)

mortendk’s picture

Issue summary: View changes
Status: Active » Needs review
Related issues: +#1995272: [Meta] Refactor module CSS files inline with our CSS standards
StatusFileSize
new2.39 KB

upsie ;)

idebr’s picture

Status: Needs review » Needs work

The original file is not deleted in your patch. Can you remove the css/file.formatter.generic.css as well?

mortendk’s picture

Status: Needs work » Needs review
StatusFileSize
new231 bytes

true lets try this again my sourcetree is acting weird

mortendk’s picture

StatusFileSize
new818 bytes

and again

The last submitted patch, 7: 2421345-7.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: 2421345-8.patch, failed testing.

ibonelli’s picture

So current status is: Code change seems proper, but it broke the tests. Looked at the errors, but I can not figure out why.

The first patch #7 triggered ExceptionHandlingTest->testBacktraceEscaping() which tests if exception backtraces are properly escaped when output to HTML.

The second patch #8 fixed some missing references on file.libraries.yml and it trigered two new simpletest errors::

  • MissingCheckedRequirementsTest->testCheckRequirements() which ensures test will not run when requirements are missing
  • Second one is simply an out-of-memory issue (after allocating 335MB), system doesn't get to show what error might be

In my mind this second error could simply be related to the out-of-memory issue. But I wasn't able to check it locally just yet.

drupalninja99’s picture

Status: Needs work » Needs review

I think maybe its just a memory issue, going to retry testing.

LewisNyman queued 8: 2421345-8.patch for re-testing.

idebr’s picture

Category: Bug report » Task
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs screenshots
StatusFileSize
new144.62 KB

Did a manual test to confirm the file theming still applies correctly:

Screenshot after:

I have updated the issue summary to include a beta evaluation.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

CSS/Markup changes are allowed during beta.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed b1281e0 on 8.0.x
    Issue #2421345 by mortendk, idebr, ibonelli: file.formatter.generic.css...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.