Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
file system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Feb 2015 at 10:23 UTC
Updated:
12 Mar 2015 at 04:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mortendk commentedComment #2
mortendk commentedComment #3
mortendk commentedComment #4
idebr commentedThere is no patch attached. Did you forget to upload one? :)
Comment #5
mortendk commentedupsie ;)
Comment #6
idebr commentedThe original file is not deleted in your patch. Can you remove the css/file.formatter.generic.css as well?
Comment #7
mortendk commentedtrue lets try this again my sourcetree is acting weird
Comment #8
mortendk commentedand again
Comment #11
ibonelli commentedSo current status is: Code change seems proper, but it broke the tests. Looked at the errors, but I can not figure out why.
The first patch #7 triggered ExceptionHandlingTest->testBacktraceEscaping() which tests if exception backtraces are properly escaped when output to HTML.
The second patch #8 fixed some missing references on file.libraries.yml and it trigered two new simpletest errors::
In my mind this second error could simply be related to the out-of-memory issue. But I wasn't able to check it locally just yet.
Comment #12
drupalninja99 commentedI think maybe its just a memory issue, going to retry testing.
Comment #14
idebr commentedDid a manual test to confirm the file theming still applies correctly:
Screenshot after:
I have updated the issue summary to include a beta evaluation.
Comment #15
webchickCSS/Markup changes are allowed during beta.
Committed and pushed to 8.0.x. Thanks!