Replace all instances of variable_del() with the configuration system.

See change record The variable_get/set/del API is now removed.

CommentFileSizeAuthor
#3 2418513-replace-variable_del-with-config-3.patch727 byteslegovaer

Comments

planctus’s picture

planctus commented
Assigned: Unassigned » planctus
planctus’s picture

planctus commented
Issue tags: -Novice +Novice d8sandwichSessions
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Active » Needs review
StatusFileSize
new 2418513-replace-variable_del-with-config-3.patch727 bytes

variable_del is no longer used now when applying the patch. But the function where it was used (scheduler_node_type_delete) should be refactored because that hook is no longer in use, I think.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Assigned: planctus » Unassigned
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Postponed
Issue tags: -Novice d8sandwichSessions +Novice, +d8sandwichSessions

These are also ThirdPartySettingsInterface settings, similar to #2418523: Replace variable_get() with config. Let's postpone this until we can implement this properly using ThirdPartySettingsTrait.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Postponed » Fixed

In the meanwhile all instances of variable_del() have been converted as part of work done in other issues, so this can be closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.