Comments

joachim’s picture

Status: Active » Needs work
StatusFileSize
new1.06 KB

Needs further work, as this looks wrong:

   * @return string
   *   Returns indication value for flagging access permission.

We're returning the result of AccessResult::allowedIf(), which according to https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Access!AccessResu... is a \Drupal\Core\Access\AccessResult.

martin107’s picture

Status: Needs work » Needs review
StatusFileSize
new825 bytes

Current patch has been superseded a duplicate issue #2428981: FlaggingAccessController::checkFlag @param is out of step with code.

This is me just wearing a hair-shirt ... I should have spotted the return thing in that issue. :)

So starting with a new patch to just correct the return type.
The text looks fine as it stands.

socketwench’s picture

Status: Needs review » Reviewed & tested by the community

That'd work for me.

  • martin107 authored a650247 on 8.x-4.x
    Issue #2415583 by joachim, martin107: Fixed documentation in...

The last submitted patch, 1: 2415583.flag_.FlaggingAccessController-check-docs.patch, failed testing.

socketwench’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.