Migration Files for Drupal 7 Custom Blocks

Postponing on #2384567: Migration Files for Drupal 7 Text Formats & Filters, since this migration depends on text formats and I'd prefer not to merge this patch into that issue.

moved files to block_content module.

This is unblocked now, since text format migration has landed.

Changing the project.

Updated with a test, and merged in #2415325: Migration Files for Drupal 7 Block Content Type.

Non-test diffs between D6 and D7.

1. +++ b/core/modules/block_content/migration_templates/d7_block_content_body_field.yml
   @@ -1,25 +1,31 @@
   +  plugin: embedded_data
   

   Can we justify changing the D6 migration to match here?

2. +++ b/core/modules/block_content/migration_templates/d7_block_content_type.yml
   @@ -1,16 +1,18 @@
   +  plugin: embedded_data
   

   Ditto.

3. +++ b/core/modules/block_content/migration_templates/d7_custom_block.yml
   @@ -1,24 +1,27 @@
   -  id: bid
   +  id:
   +    plugin: dedupe_entity
   +    entity_type: block_content
   +    field: id
   +    length: 32
   

   Why dedupe in the D7 migration but not the D6 migration? Also, should field: id be bid instead?

4. +++ b/core/modules/block_content/migration_templates/d7_custom_block.yml
   @@ -1,24 +1,27 @@
   -  no_stub: true
   

   Why would we suppress stubbing in D6 but allow it in D7?

Back to nw - the stubbing thing definitely looks wrong, and I'm awfully suspicious of the id/bid business.

Ah, it's not the field: id that's wrong, but it's missing source: bid, I think.

I generalized the block_content_type and block_content_body_field migrations, which also required adding an update hook to block_content.

Why dedupe in the D7 migration but not the D6 migration? Also, should field: id be bid instead?

No reason, as far as I can tell. Changed it to a direct mapping.

Why would we suppress stubbing in D6 but allow it in D7?

I don't know -- probably a question best directed at @benjy -- but no_stub is rarely used so I can only assume it was done for a good reason. I have added it to the D7 migration.

Apologies for the length of the interdiff -- git seems to think that I rewrote entire files, instead of just moving a few things around.

D'oh! Forgot to alter a couple of tests.

Stupid git managed to leave a file out of the patch in #17.

On @gàbor-hojtsy's advice, changed the update hook to use the lower-level config API, rather than the entity system.

Forgot to call save(TRUE) in the update hook.

Interdiff since the last patch I reviewed - a lot's changed...

Here we go!

Ok, reviewed this LIVE with Adam, Mike, and quietone. Works as advertised, once you manually place the block!

WOOHOO!

Committed and pushed to 8.0.x. Thanks!

Works as advertised, once you manually place the block!

Can we not map the blocks into the correct regions, for the core themes?

Yes. My understanding is that's happening at #2408165: Migration Files for Drupal 7 Blocks.